add tests for transaction-planner #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valentine1898
commented
Mar 6, 2024
Comment on lines
+14
to
+17
| const mockPlanTransaction = vi.hoisted(() => vi.fn()); | ||
| vi.mock('@penumbra-zone/wasm', () => ({ | ||
| planTransaction: mockPlanTransaction, | ||
| })); |
There was a problem hiding this comment.
We didn't get rid of the indexed-db global in wasm and we don't have that goal anymore, so we have no choice but to use mock here
|
web/packages/wasm/crate/tests/build.rs Lines 413 to 420 in 1edd2af Actually wasm planner is tested with one case in rust tests, I think in future we need to write more rust tests for wasm planner |
|
Agree, tests in the crate will be far more meaningful. Could you create a tracking issue with a proposal of tests we can write for the crate to increase coverage on that side? |
grod220
approved these changes
Mar 6, 2024
Yep #691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The simplification of wasm transaction planner #609 is already finished, so it no longer makes sense for us to hold off on these tests