Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fees: add tests to validate that non-zero fees are working #4155

Open
Tracked by #3367
TalDerei opened this issue Apr 3, 2024 · 1 comment
Open
Tracked by #3367

fees: add tests to validate that non-zero fees are working #4155

TalDerei opened this issue Apr 3, 2024 · 1 comment
Assignees
Labels
A-fees Area: Relates to transaction fees A-testing Area: Relates to testing of Penumbra _P-low Priority: low

Comments

@TalDerei
Copy link
Collaborator

TalDerei commented Apr 3, 2024

Create unit tests to verify correctness of non-zero fees in the context of properly balancing transactions. There are a few cases to consider:

  • single large note > amount + cumulative fees --> success
  • single small note < amount + cumulative fees --> failure
  • multiple smaller notes > amount + cumulative fees --> success
  • multiple smaller notes < amount + cumulative fees --> failure
  • exact note for amount + another large note > amount + cumulative fees --> success
  • exact note for amount + another small note < amount + cumulative fees --> failure
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 3, 2024
@TalDerei TalDerei self-assigned this Apr 4, 2024
@TalDerei TalDerei added _P-V1 Priority: slated for V1 release A-testing Area: Relates to testing of Penumbra labels Apr 4, 2024
@aubrika aubrika added this to the Sprint 4 milestone Apr 8, 2024
@aubrika aubrika moved this from Backlog to Todo in Penumbra Apr 8, 2024
@TalDerei TalDerei moved this from Todo to In progress in Penumbra Apr 14, 2024
@TalDerei
Copy link
Collaborator Author

tagging penumbra-zone/web#690 for visibility.

@cratelyn cratelyn modified the milestones: Sprint 4, Sprint 5 Apr 22, 2024
@TalDerei TalDerei changed the title add tests to validate that fees are working fees: add tests to validate that non-zero fees are working Apr 27, 2024
@TalDerei TalDerei added the A-fees Area: Relates to transaction fees label Apr 27, 2024
@TalDerei TalDerei mentioned this issue May 4, 2024
1 task
@aubrika aubrika added the friction something made this fall into the following milestone & the reason should be noted in a comment label May 6, 2024
@aubrika aubrika modified the milestones: Sprint 5, Sprint 6 May 6, 2024
@aubrika aubrika moved this from In progress to Todo in Penumbra May 6, 2024
@aubrika aubrika removed the on hold label May 6, 2024
@cratelyn cratelyn removed the friction something made this fall into the following milestone & the reason should be noted in a comment label May 6, 2024
@TalDerei TalDerei moved this from Todo to Backlog in Penumbra May 20, 2024
@aubrika aubrika moved this from Backlog to Todo in Penumbra May 20, 2024
@aubrika aubrika modified the milestones: Sprint 6, Sprint 7 May 20, 2024
@aubrika aubrika moved this from Todo to Backlog in Penumbra May 20, 2024
@aubrika aubrika removed the _P-V1 Priority: slated for V1 release label May 31, 2024
@TalDerei TalDerei added the _P-low Priority: low label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-fees Area: Relates to transaction fees A-testing Area: Relates to testing of Penumbra _P-low Priority: low
Projects
Status: Backlog
Development

No branches or pull requests

3 participants