Optimize assorted Django operations

backend/clubs/management/commands/update_club_counts.py

@@ -1,5 +1,5 @@
 from django.core.management.base import BaseCommand
-from django.db.models import Count, Q
+from django.db.models import Count, OuterRef, Q, Subquery
 
 from clubs.models import Club
 
@@ -9,17 +9,23 @@
 
     def handle(self, *args, **kwargs):
         try:
-            queryset = Club.objects.all().annotate(
-                temp_favorite_count=Count("favorite", distinct=True),
-                temp_membership_count=Count(
-                    "membership", distinct=True, filter=Q(active=True)
-                ),
+            favorite_count_subquery = (
+                Club.objects.filter(pk=OuterRef("pk"))
+                .annotate(count=Count("favorite", distinct=True))
+                .values("count")
+            )
+            membership_count_subquery = (
+                Club.objects.filter(pk=OuterRef("pk"))
+                .annotate(
+                    count=Count("membership", distinct=True, filter=Q(active=True))
+                )
+                .values("count")
             )
 
-            for club in queryset:
-                club.favorite_count = club.temp_favorite_count
-                club.membership_count = club.temp_membership_count
-            Club.objects.bulk_update(queryset, ["favorite_count", "membership_count"])
+            Club.objects.update(
+                favorite_count=Subquery(favorite_count_subquery),
+                membership_count=Subquery(membership_count_subquery),
+            )
 
             self.stdout.write(
                 self.style.SUCCESS(

backend/clubs/models.py

@@ -13,7 +13,7 @@
 from django.core.exceptions import ValidationError
 from django.core.mail import EmailMultiAlternatives
 from django.core.validators import validate_email
-from django.db import models, transaction
+from django.db import models
 from django.db.models import Sum
 from django.dispatch import receiver
 from django.template.loader import render_to_string
@@ -833,21 +833,33 @@ def create_events(
         club_query = self.participating_clubs.all()
         if filter is not None:
             club_query = club_query.filter(filter)
-        events = []
-        with transaction.atomic():
-            for club in club_query:
-                obj, _ = Event.objects.get_or_create(
-                    code=f"fair-{club.code}-{self.id}-{suffix}",
-                    club=club,
-                    type=Event.FAIR,
-                    defaults={
-                        "name": self.name,
-                        "start_time": start_time,
-                        "end_time": end_time,
-                    },
+
+        # Find events that already exist
+        event_codes = [f"fair-{club.code}-{self.id}-{suffix}" for club in club_query]
+        existing_events = Event.objects.filter(code__in=event_codes).values_list(
+            "code", flat=True
+        )
+
+        # Create new events in bulk
+        new_events = []
+        for club in club_query:
+            event_code = f"fair-{club.code}-{self.id}-{suffix}"
+            if event_code not in existing_events:
+                new_events.append(
+                    Event(
+                        code=event_code,
+                        club=club,
+                        type=Event.FAIR,
+                        name=self.name,
+                        start_time=start_time,
+                        end_time=end_time,
+                    )
                 )
-                events.append(obj)
-        return events
+        Event.objects.bulk_create(new_events)
+
+        # Return all event objects
+        events = Event.objects.filter(code__in=event_codes)
+        return list(events)
 
     def __str__(self):
         fmt = "%b %d, %Y"