-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize assorted Django operations #627
Open
aviupadhyayula
wants to merge
17
commits into
master
Choose a base branch
from
optimize-orm
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 69.11% 69.29% +0.17%
==========================================
Files 30 30
Lines 6362 6353 -9
==========================================
+ Hits 4397 4402 +5
+ Misses 1965 1951 -14 ☔ View full report in Codecov by Sentry. |
rohangpta
reviewed
Mar 11, 2024
aviupadhyayula
changed the title
Optimize Django operations
Optimize assorted Django operations
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to generally optimize our usage of the Django ORM, with a focus on taking full advantage of major upgrades in #605.
Changelog:
update_club_counts
. Shows a ~70% speedup in local benchmarks (n=2000 memberships/favorites).bulk_create
plays withAutoField
primary keys (like we have for theEvents
model). But, the documentation mentions that pSQL should be fine.[1]Events
objects doesn't matter. Would appreciate a second set of eyes.qs.exists()
to check existence instead ofqs.first() is not None
whenever possible.[1] https://docs.djangoproject.com/en/5.0/ref/models/querysets/#bulk-create