Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sevral supported printers to brlaser #92

Closed
wants to merge 18 commits into from

Conversation

QORTEC
Copy link
Contributor

@QORTEC QORTEC commented Oct 6, 2020

Since I had some extra time I decided to help out adding the supported printers to brlaser.

#66 DCP-L2510D
#87 DCP-L2537DW
#63 HL-2130
#90 HL-L2380DW
#77 MFC-7340
#50 MFC-8710DW
#83 MFC-L3750CDW

@jakubgs
Copy link

jakubgs commented Mar 8, 2021

Any news on this?

Closes pdewacht#98  DCP-T500W
Closes pdewacht#94  HL-5040
Closes pdewacht#101 HL-2250DN
Closes pdewacht#112 HL-L2305
Closes pdewacht#109 MFC-1810
Closes pdewacht#115 MFC-7320
Closes pdewacht#114 MFC-L2700DN
HL-2130
 - remove duplex

HL-L2380DW
 - remove 300dpi
 - add duplex

MFC-7340
 - remove duplex
@QORTEC
Copy link
Contributor Author

QORTEC commented Mar 15, 2021

At it again;

Printers Definitions Added:
#98 DCP-T500W
#88 DCP-T710W
#94 HL-5040
#101 HL-2250DN
#112 HL-L2305
#109 MFC-1810
#115 MFC-7320
#114 MFC-L2700DN

Errors Fixed:

HL-L2380DW

  • removed Resolution k 1 0 0 0 "300dpi/300 DPI" since printer support is unknown
  • added Duplex rotated since its a duplex printer

MFC-7340

  • removed Duplex rotated since its not a duplex printer

HL-2130

  • removed Duplex rotated since its not a duplex printer

HL-2130
MFC-7340
MFC-8710DW
Closes pdewacht#102 DCP-L2550DW
Closes pdewacht#108 HL-L2310D
Closes pdewacht#103 HL-L2350DW
Closes pdewacht#57  MFC-L2750DW
Closes pdewacht#110 MFC-T910DW

Moved HL-L2305 definition to correct position
from after HL-L2320D
to before  HL-L2310D
@QORTEC
Copy link
Contributor Author

QORTEC commented Mar 15, 2021

Printers Definitions Added:
#102 DCP-L2550DW
#108 HL-L2310D
#103 HL-L2350DW
#57 MFC-L2750DW
#110 MFC-T910DW

Errors Fixed:

Moved HL-L2305 definition to correct position

  • from after HL-L2320D
  • to before HL-L2310D

@corna corna mentioned this pull request Apr 6, 2021
@Rapti
Copy link

Rapti commented May 27, 2021

I can confirm that this fork works with my MFC-7320 on a Raspberry Pi 2B.

@zeroheure
Copy link

@QORTEC I've wrote to @pdewacht requesting to have a look. May be you could ask him to co-maintained this driver ?

@QORTEC
Copy link
Contributor Author

QORTEC commented Jan 9, 2022

@zeroheure
If it would helpful for @pdewacht, I would be happy to occasionally go through and add driver definitions, it's a simple straightforward process.

Unfortunately that would be the limit of my help, since I don't know c++...

@zeroheure
Copy link

I can help on that too. That's why I wrote the wiki page. I don't know C++ neither.
Didn't get answer from @pdewacht yet.

@QORTEC
Copy link
Contributor Author

QORTEC commented Jan 12, 2022

I just started to look at the pull request in detail.
Closing this pull request until it is fixed.

@QORTEC QORTEC closed this Jan 12, 2022
Closes pdewacht#141 Brother DCP-7020
Closes pdewacht#147 Brother HL-2230  series
Closes pdewacht#121 Brother HL-2240D series
Closes pdewacht#128 Brother HL-2280DW
Closes pdewacht#144 Brother MFC-7440N
Closes pdewacht#129 Brother MFC-8860DN
Closes pdewacht#134 Brother MFC-L2700DW series
Closes pdewacht#130 Brother MFC-L2710DN series
Closes pdewacht#142 Lenovo LJ2650DN
 - DCP-L2537DW
 - DCP-L2550DW
 - HL-L2350DW
 - MFC-L2700DN
 - MFC-L2700DW
 - MFC-L2710DN
 - MFC-L2750DW

Use standard naming convention for ModelName:
 - HL-2250DN
 - HL-2250DN
 - MFC-L2750DW
 - MFC-L3750CDW
@QORTEC
Copy link
Contributor Author

QORTEC commented Jan 12, 2022

Everything should be good to go

@QORTEC QORTEC reopened this Jan 12, 2022
@QORTEC
Copy link
Contributor Author

QORTEC commented Jan 12, 2022

Removed unsupported printers form pull request (Inkjet):
#98 DCP-T500W
#88 DCP-T710W
#110 MFC-T910DW

Corrected ppd file names from earlier in pull request:

  • DCP-L2537DW
  • DCP-L2550DW
  • HL-L2350DW
  • MFC-L2700DN
  • MFC-L2750DW

Follow the standard naming convention for ModelName:

  • HL-2250DN
  • HL-2250DN
  • MFC-L2750DW
  • MFC-L3750CDW

Printers Definitions Added:
#141 Brother DCP-7020
#147 Brother HL-2230
#121 Brother HL-2240D
#128 Brother HL-2280DW
#144 Brother MFC-7440N
#129 Brother MFC-8860DN
#134 Brother MFC-L2700DW
#130 Brother MFC-L2710DN
#142 Lenovo LJ2650DN

I used the ln prefix for the Lenovo .ppd file since there was no predefined prefix.

"Lenovo" is a portmanteau of "Le-" (from Legend) and "novo", Latin ablative for "new".
Wikipedia

If there are any issues, or you would like some changes let me know.

@QORTEC
Copy link
Contributor Author

QORTEC commented Jan 13, 2022

Added FujiXerox DocuPrint P265 dw (#150)

I ended up using the fx prefix for the FujiXerox .ppd

There's something especially satisfying to see other printer brands work with the driver, and I'm not really that involved in the project.

Closes pdewacht#156 Brother HL-L5000D series
Closes pdewacht#162 Brother HL-L2370DN series
Closes pdewacht#172 Brother DCP-8065DN

Fixed definition formatting for DocuPrint P265 dw
@zeroheure
Copy link

zeroheure commented Dec 19, 2022

Here's the answer from Till Kampeeter

I have written an e-mail to Peter de Wachter now. I hope that he will answer to me as the official printing guru.

I have suggested him to transfer brlaser to OpenPrinting. I f he answers and I succeed, it will be simple for you. You post pull requests and I will handle them. If all works fine with your changed I will also give you direct push access

(I guess the "you" is not for me, but collective)

@QORTEC
Copy link
Contributor Author

QORTEC commented Dec 19, 2022

Thanks for keeping us updated. It would definitely be nice to have the changes merged and issues closed.

Fork wise I'll probably tag a release sometime tomorrow or the day after, there weren't many changes this time.

@axelsommerfeldt
Copy link

Though I will probably be conservative on accepting code changes, since I done know the language well enough to judge code quality. If there anyone who wants to help maintain the code side of the project that would be appreciated.

I could do that. (I'm a professional C/C++ software developer since 1995, and I'm maintaining several LaTeX packages since 1994, currently on GitLab. BUT: I have absolutely no knowledge of writing CUPS drivers yet. So I would not be the best choice for this job.)

Furthermore I would like to comment the sources (using doxygen syntax) since there are only 6 comments (not counting the copyright header) in the complete project C++ files.

@QORTEC
Copy link
Contributor Author

QORTEC commented Dec 19, 2022

Though I will probably be conservative on accepting code changes, since I done know the language well enough to judge code quality. If there anyone who wants to help maintain the code side of the project that would be appreciated.

I could do that. (I'm a professional C/C++ software developer since 1995, and I'm maintaining several LaTeX packages since 1994, currently on GitLab. BUT: I have absolutely no knowledge of writing CUPS drivers yet. So I would not be the best choice for this job.)

Thank you any amount of help would be greatly appreciated.

Furthermore I would like to comment the sources (using doxygen syntax) since there are only 6 comments (not counting the copyright header) in the complete project C++ files.

That will definitely help in the long run, thanks again.

Unless poked, I tend to only check back every 2-6 months to respond to issues and add printer definitions. Let me know when there are changes that I should pull in...

@QORTEC
Copy link
Contributor Author

QORTEC commented Dec 25, 2022

Merry Christmas/Happy Holidays;
I just found the time to create a new release.

Notable additions/changes since last the summery;

Printers Definitions Added:
#107 Brother DCP-7070DW (Pull Request)
#172 Brother DCP-8065DN
#156 Brother HL-L5000D series
#162 Brother HL-L2370DN series

Errors Fixed:
#133 Fixed PCFileName br7365dn.ppd > br7460dn.ppd for MFC-7460DN. (Pull Request)

Changed Code:
#169 Explicitly disabled duplex using standard PCL code. (Pull Request)

Issues Resolved:
#169 Fixing the issue where printer HL-L2350DW continued to duplex even when disabled, however every other page was garbled. (Pull Request)

@QORTEC
Copy link
Contributor Author

QORTEC commented Mar 14, 2023

Closing this in favour of pull requests #179 and #180

Pull request #179 based off of the definitions branch, which focuses on adding printer entries to the driver. This pull request (#92) focuses on adding printer entries to the driver.
Given the nature of the changes made, @pdewacht should be able to promptly accept this pull request.

Pull request #180 based off of the code branch, which focuses changes to the codebase. This includes #169, with QORTEC#2 later expanding its functionality to explicitly set simplex, duplex no tumble, and duplex tumble modes
Due to the nature of the changes, @pdewacht will likely want to verify that the code works as expected and doesn't cause any issues

Moving forward, I'll be abandoning QORTEC/brlaser if favour of Owl-Maintain/brlaser. The Owl-Maintain fork is virtually identical to this pull request, with the only difference being an updated README.md and Github Issues Templates on the master branch.

@QORTEC QORTEC closed this Mar 14, 2023
ahydronous added a commit to ahydronous/nixpkgs that referenced this pull request Sep 21, 2024
brlaser: Fedora switched to a more-maintained upstream fork because it supports more printers.

See: https://packages.fedoraproject.org/pkgs/printer-driver-brlaser/printer-driver-brlaser/index.html
and
pdewacht/brlaser#92

brlaser: switch to same more-maintained upstream as Fedora

Fedora switched to a more-maintained upstream fork because it supports more printers.

See: https://packages.fedoraproject.org/pkgs/printer-driver-brlaser/printer-driver-brlaser/index.html
and
pdewacht/brlaser#92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants