Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DCP7070-DW #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adding DCP7070-DW #166

wants to merge 1 commit into from

Conversation

loicdb75
Copy link

I added an entry for the printer DCP7070-DW.
Works fine

@QORTEC
Copy link
Contributor

QORTEC commented Dec 19, 2022

Thanks for submitting a pull request, interestingly pull request #107 for the DCP-7070DW was closed a month before your you opened yours.

I pushed an update to my pull request #92, in which I've merged support for the DCP-7070DW using the earlier pull request.

Taking a quick look, looks like the attributes from the earlier pull request and yours don't match. I don't know if this would effect anything, but I wouldn't expect it to.

Attribute "1284DeviceID" "" "MFG:Brother;CMD:PJL,PCL,PCLXL;MDL:DCP-7070DW;CLS:PRINTER;CID:Brother Laser Type1;"
Attribute "1284DeviceID" "" "MFG:Brother;CMD:PJL,HBP;      MDL:DCP-7070DW;CLS:PRINTER;CID:Brother Laser Type1;"

@loicdb75
Copy link
Author

As I mentionned, my entry works fine (raspbian on a raspberry cm4), but I think the #92 is a better one.
After further verification, the DCP7070-DW is compatible PCL6 (PCLXL), and I didn't test HPB capability. the PR #92 seems to be more reliable than mine.

You can forget my quick and dirty fix, and thank you for maintaining your code !

@QORTEC
Copy link
Contributor

QORTEC commented Dec 19, 2022

Thanks, happy it's of use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants