Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overhaul error handling in projectionist #504

Merged
merged 5 commits into from
Feb 26, 2024
Merged

overhaul error handling in projectionist #504

merged 5 commits into from
Feb 26, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Feb 20, 2024 •
edited
Loading

The error handling was refactored again and a RetryStrategy was added. This means that failed projections can be tried again several times after a certain time.

@DavidBadura DavidBadura added enhancement New feature or request BC-Break labels Feb 20, 2024
@DavidBadura DavidBadura added this to the 3.0.0 milestone Feb 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2024 •
edited
Loading

Hello 👋

here is the most recent benchmark result: 

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events ()                | 167.705ms (±0.00%) | 165.430ms (±0.00%) | 41.097mb        | 41.097mb   |
| benchSave1Event ()                     | 1.202ms (±0.00%)   | 1.201ms (±0.00%)   | 41.097mb        | 41.097mb   |
| benchSave10000Events ()                | 343.937ms (±0.00%) | 344.854ms (±0.00%) | 41.364mb        | 41.364mb   |
| benchSave10000Aggregates ()            | 10.794s (±0.00%)   | 11.488s (±0.00%)   | 41.097mb        | 41.097mb   |
| benchSave10000AggregatesTransaction () | 928.948ms (±0.00%) | 945.079ms (±0.00%) | 41.097mb        | 41.097mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------------+------------+
|                                        | time (kde mode)                         | memory                       |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| subject                                | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+----------------------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000EventsMissingSnapshot () | 166.710ms (±0.00%) | 166.230ms (±0.00%) | 41.114mb        | 41.114mb   |
| benchLoad10000Events ()                | 204.800μs (±0.00%) | 201.000μs (±0.00%) | 41.114mb        | 41.114mb   |
+----------------------------------------+--------------------+--------------------+-----------------+------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------------+------------+
|                         | time (kde mode)                         | memory                       |
+-------------------------+--------------------+--------------------+-----------------+------------+
| subject                 | Tag: <current>     | Tag: base          | Tag: <current>  | Tag: base  |
+-------------------------+--------------------+--------------------+-----------------+------------+
| benchLoad10000Events () | 2.779ms (±0.00%)   | 2.795ms (±0.00%)   | 44.544mb        | 44.544mb   |
| benchSave10000Events () | 366.753ms (±0.00%) | 366.071ms (±0.00%) | 44.842mb        | 44.841mb   |
+-------------------------+--------------------+--------------------+-----------------+------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura force-pushed the overhaul-error-handling-in-projectionist branch 2 times, most recently from a192d76 to ddb01fd Compare February 20, 2024 13:14
@DavidBadura DavidBadura force-pushed the overhaul-error-handling-in-projectionist branch from ddb01fd to d592037 Compare February 21, 2024 11:18
@DavidBadura DavidBadura marked this pull request as ready for review February 21, 2024 12:10
@DavidBadura DavidBadura force-pushed the overhaul-error-handling-in-projectionist branch from aa3da2a to 052e3c1 Compare February 21, 2024 12:53
@DavidBadura DavidBadura force-pushed the overhaul-error-handling-in-projectionist branch from 052e3c1 to 5609182 Compare February 21, 2024 13:03
@DavidBadura DavidBadura force-pushed the overhaul-error-handling-in-projectionist branch from 14d1897 to c582ede Compare February 22, 2024 20:04
@DavidBadura DavidBadura merged commit f657fa0 into 3.0.x Feb 26, 2024
32 of 33 checks passed
@DavidBadura DavidBadura deleted the overhaul-error-handling-in-projectionist branch February 26, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBadura DanielBadura DanielBadura approved these changes

Assignees
No one assigned
Labels
BC-Break enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidBadura @DanielBadura