Add punctuation inventory #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfheij-sil
commented
Dec 17, 2024
There was a problem hiding this comment.
Because of issue #1384 a lot of logic related to interfaces will change. I still want to get this inventory in, but I commented out a number of large functions that will probably be changed or removed in the future, to save the reviewers some time. I apologize for the heresy of commiting commented code
Reviewable status: 0 of 11 files reviewed, all discussions resolved
lyonsil
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Normally I'd push back on the commented-out code, but I understand in this case.
Reviewed 6 of 11 files at r1, 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is