Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Punctuation Check Configuration #458

Open
katherinejensen00 opened this issue Sep 26, 2023 · 2 comments
Open

Create Punctuation Check Configuration #458

katherinejensen00 opened this issue Sep 26, 2023 · 2 comments
Assignees
Labels
BLOCKED Waiting on something before able to be worked extensions team Able to be worked on by extensions team

Comments

@katherinejensen00
Copy link
Contributor

katherinejensen00 commented Sep 26, 2023

As a user, I need to check the accuracy and consistency of the usage of punctuation in the translation so that I can have a quality error free publication of the translation.

Add configuration functionality for the Punctuation Check.

Note: This check can be done with or without sequences so make sure to account for that when creating this check. Will those need to be separate checks or one check with a setting?

The C# punctuation check uses the following info. Please add ways to configure where relevant (please investigate):

  • Punctuation Inventory
  • Markers missing final punctuation inventory (maybe?)
  • Punctuation followed by lowercase inventory
  • Unmatched pairs of punctuation inventory
  • Stylesheet of the project
  • Quote settings (from Quotation Rules in Project Settings)
  • WordMedialPunctuation settings

Depends on #449

@katherinejensen00 katherinejensen00 added the extensions team Able to be worked on by extensions team label Sep 26, 2023
@katherinejensen00 katherinejensen00 added this to the Checks milestone Sep 26, 2023
@katherinejensen00 katherinejensen00 moved this to Open in Paranext Sep 26, 2023
@lyonsil lyonsil removed this from the Checks milestone Sep 29, 2023
@katherinejensen00 katherinejensen00 moved this from 📥 On Deck to 🎬 Product Backlog in Paranext Jun 3, 2024
@tjcouch-sil tjcouch-sil changed the title Create Punctuation Check Create Punctuation Check Configuration Oct 2, 2024
@tjcouch-sil tjcouch-sil moved this from 🎬 Product Backlog to 🔖 ToDo in Paranext Oct 2, 2024
@katherinejensen00 katherinejensen00 moved this from 🔖 ToDo to 🎬 Product Backlog in Paranext Oct 16, 2024
@katherinejensen00 katherinejensen00 moved this from 🎬 Product Backlog to 🔖 ToDo in Paranext Oct 16, 2024
@katherinejensen00 katherinejensen00 moved this from 🔖 ToDo to 🎬 Product Backlog in Paranext Oct 30, 2024
@katherinejensen00 katherinejensen00 moved this from 🎬 Product Backlog to 🔖 ToDo in Paranext Nov 27, 2024
@rolfheij-sil rolfheij-sil moved this from 🔖 ToDo to 🏗 In progress in Paranext Dec 9, 2024
@rolfheij-sil rolfheij-sil self-assigned this Dec 9, 2024
@rolfheij-sil
Copy link
Contributor

There are four inventories related to punctuation:

  • Punctuation inventory. Related settings are ValidPunctuation and InvalidPunctuation. Project settings -> Language settings -> Other characters also has a Word-medial punctuation field that I don't see reflected in Settings.xml, so it is not considered for now. Added in PR 1383
  • Unmatched pair of punctuation inventory. Related setting are Pairs (unclear how this can be configured from the PT9 UI), MatchedPairingCharacters and UnmatchedPairingCharacters
  • Punctuation followed by lowercase letter inventory. Related settings are ValidSentenceFinalPunctCapitalization and InvalidSentenceFinalPunctCapitalization
  • Markers missing final punctuation inventory. This one might be considered a Marker check more so than a Punctuation check, so we can choose to not implement it for now. It also has a lot of settings that are related to it. At least these ones: MarkersCheckedForFinalPunctuation, MarkersStartingNewSentencesForFinalPunctuation, MarkersSkippedForFinalPunctuation, CheckFinalPunctuationInFootnotes, CheckFinalPunctuationInCrossRefs, CheckFinalPunctuationInFigures, IgnoreWhenFollowedByFinalPunctuationParameter, ValidParagraphFinalPunctuationItems, InvalidParagraphFinalPunctuationItems

And then there's these three punctuation setings that I don't know about what check (if any) they are related to: SentenceFinalPunctuation, ReferenceFinalPunctuation, SegmentsMustHaveFinalPunctuation

@rolfheij-sil rolfheij-sil moved this from 🏗 In progress to 🔖 ToDo in Paranext Dec 16, 2024
@rolfheij-sil rolfheij-sil added the BLOCKED Waiting on something before able to be worked label Dec 16, 2024
@rolfheij-sil
Copy link
Contributor

Work on inventories is blocked until #1384 is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKED Waiting on something before able to be worked extensions team Able to be worked on by extensions team
Projects
Status: 🔖 ToDo
Development

No branches or pull requests

4 participants