Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks: Get inventory data from Paratext.Checks #1384

Open
rolfheij-sil opened this issue Dec 11, 2024 · 0 comments
Open

Checks: Get inventory data from Paratext.Checks #1384

rolfheij-sil opened this issue Dec 11, 2024 · 0 comments

Comments

@rolfheij-sil
Copy link
Contributor

As a developer I want to extract inventory related data from Paratext 9 checking code, so that the items that are shown in the inventories in PT10 are the exact same items that the PT9 checking code is processing
As a user I want the inventories and the checks to consider the exact same data, so that I can be confident that the items that I can see and configure in the inventories are the items that the checks operate on

Currently the CheckRunner class in Platform is calling parts of the Paratext.Checks code to run basic checks.
The code that runs these checks is very closely coupled to the code that populates the checking inventories in PT9.

However, we do not currently have access to the list of inventory items that the Paratext,Checks code generates. The inventories in Platform use their own regular expressions or custom functions to identify what items should be displayed in them, and there is no way to know if these are the same items that the checks are actually running on.

We need to extend the CheckRunner so that it doesn't only get the checking results, but also gets the inventory items that the checks are operating on, so that there is no discrepancy between the items shown in the inventories and the items that the checks are running on, and so that the user has control over the validity of these items through the inventories in Platform

@rolfheij-sil rolfheij-sil converted this from a draft issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📥 For Consideration
Development

No branches or pull requests

1 participant