- more code review

- also make VS Code use the repo TS version

.vscode/settings.json

@@ -23,6 +23,7 @@
   "javascript.validate.enable": false,
   "javascript.format.enable": false,
   "typescript.format.enable": false,
+  "typescript.tsdk": "node_modules/typescript/lib",
 
   "search.exclude": {
     ".git": true,

extensions/src/c-sharp-provider-test/index.d.ts

@@ -1,4 +1,5 @@
 declare module 'c-sharp-provider-test' {
+  // @ts-ignore: TS2307 - Cannot find module '@papi/core' or its corresponding type declarations
   import { IDataProvider, DataProviderDataType } from '@papi/core';
 
   type TimeDataTypes = {

extensions/src/hello-someone/src/types/hello-someone.d.ts

@@ -1,4 +1,5 @@
 declare module 'hello-someone' {
+  // @ts-ignore: TS2307 - Cannot find module '@papi/core' or its corresponding type declarations
   import { IDataProvider, DataProviderDataType } from '@papi/core';
 
   export type Person = {

extensions/src/hello-world/src/types/hello-world.d.ts

@@ -1,4 +1,5 @@
 declare module 'hello-world' {
+  // @ts-ignore: TS2307 - Cannot find module '@papi/core' or its corresponding type declarations
   import type { DataProviderDataType, MandatoryProjectDataTypes } from '@papi/core';
   import type { IBaseProjectDataProvider } from 'papi-shared-types';
 

extensions/src/platform-scripture/src/types/platform-scripture.d.ts

@@ -6,6 +6,7 @@ declare module 'platform-scripture' {
     DataProviderUpdateInstructions,
     ExtensionDataScope,
     IDataProvider,
+    // @ts-ignore: TS2307 - Cannot find module '@papi/core' or its corresponding type declarations
   } from '@papi/core';
   import type { IProjectDataProvider } from 'papi-shared-types';
   import { Dispose, LocalizeKey, UnsubscriberAsync } from 'platform-bible-utils';

extensions/src/project-notes-data-provider/index.d.ts

@@ -3,6 +3,7 @@ import type {
   DataProviderDataType,
   DataProviderSubscriberOptions,
   IDataProvider,
+  // @ts-ignore: TS2307 - Cannot find module '@papi/core' or its corresponding type declarations
 } from '@papi/core';
 import { PlatformEvent, Unsubscriber } from 'platform-bible-utils';
 

extensions/src/quick-verse/src/types/quick-verse.d.ts

@@ -1,4 +1,5 @@
 declare module 'quick-verse' {
+  // @ts-ignore: TS2307 - Cannot find module '@papi/core' or its corresponding type declarations
   import { DataProviderDataType, IDataProvider } from '@papi/core';
 
   export type QuickVerseSetData = string | { text: string; isHeresy: boolean };

lib/platform-bible-react/package.json

@@ -40,7 +40,7 @@
     "lint-fix": "npm run lint-fix:scripts && npm run lint:styles -- --fix",
     "lint-fix:scripts": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint:scripts",
     "test": "jest --silent",
-    "typecheck": "tsc -p ./tsconfig.lint.json"
+    "typecheck": "tsc -p ./tsconfig.json"
   },
   "peerDependencies": {
     "react": ">=18.2.0",

lib/platform-bible-react/tsconfig.json

@@ -9,7 +9,7 @@
     // directories looking for node_modules/@types folders by default.
     // We needed to remove react from here below because having two copies was causing problems in
     // the jest tests. But we need the types in both places.
-    "typeRoots": ["./node_modules/@types", "../../node_modules/@types", "./@types"],
+    "typeRoots": ["./node_modules/@types", "../../node_modules/@types"],
     "lib": ["ESNext", "DOM", "DOM.Iterable"],
     "forceConsistentCasingInFileNames": true,
     "incremental": false,

lib/platform-bible-react/tsconfig.lint.json

@@ -1,7 +1,4 @@
 {
   "extends": "./tsconfig",
-  "compilerOptions": {
-    "skipLibCheck": true
-  },
-  "include": [".eslintrc.cjs", "postcss.config.js", "*.ts", "src", "@types"]
+  "include": [".eslintrc.cjs", "postcss.config.js", "*.ts", "src"]
 }

lib/platform-bible-utils/package.json

@@ -37,7 +37,7 @@
     "lint-fix": "npm run lint-fix:scripts",
     "lint-fix:scripts": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint:scripts",
     "test": "jest --silent",
-    "typecheck": "tsc -p ./tsconfig.lint.json"
+    "typecheck": "tsc -p ./tsconfig.json"
   },
   "peerDependencies": {},
   "dependencies": {

lib/platform-bible-utils/tsconfig.lint.json

@@ -1,7 +1,4 @@
 {
   "extends": "./tsconfig",
-  "compilerOptions": {
-    "skipLibCheck": true
-  },
   "include": [".eslintrc.cjs", "*.ts", "src"]
 }

package.json

@@ -87,8 +87,8 @@
     "storybook:build": "storybook build",
     "test": "npm run test:core && npm run test --workspaces --if-present",
     "test:core": "jest --silent",
-    "typecheck": "npm run typecheck:core && npm run typecheck:extensions && npm run typecheck:papi-dts && npm run typecheck:platform-bible-utils && npm run typecheck:platform-bible-react",
-    "typecheck:core": "tsc -p ./tsconfig.lint.json",
+    "typecheck": "npm run typecheck:core && npm run typecheck --workspaces --if-present",
+    "typecheck:core": "tsc -p ./tsconfig.json",
     "typecheck:extensions": "cd extensions && npm run typecheck",
     "typecheck:papi-dts": "cd lib/papi-dts && npm run typecheck",
     "typecheck:platform-bible-react": "cd lib/platform-bible-react && npm run typecheck",

tsconfig.json

@@ -25,7 +25,7 @@
       // Include extensions' type declarations
       "./extensions/src",
       // Include additions and overrides
-      "src/@types"
+      "./src/@types"
     ],
     "allowJs": true,
     "allowSyntheticDefaultImports": true,
@@ -38,9 +38,10 @@
     "resolveJsonModule": true,
     "outDir": ".erb/dll"
   },
-  "include": ["src", "assets"],
+  "include": ["src", "assets", "!**/*.test.{ts,tsx}"],
   "exclude": [
     "node_modules",
+    "dist",
     "test",
     "release/build",
     "release/app/dist",

tsconfig.lint.json

@@ -1,11 +1,7 @@
 {
   "extends": "./tsconfig",
-  "compilerOptions": {
-    "skipLibCheck": true
-  },
   "include": [
     ".eslintrc.js",
-    ".eslintrc.cjs",
     "*.ts",
     ".erb/configs",
     ".erb/mocks",