Skip to content

Commit

Permalink
- code review
Browse files Browse the repository at this point in the history
  • Loading branch information
irahopkinson committed Aug 27, 2024
1 parent 7bb2b63 commit 5075672
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 7 deletions.
3 changes: 2 additions & 1 deletion lib/papi-dts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
"clean": "rimraf papi.tsbuildinfo",
"lint": "cross-env NODE_ENV=development eslint --ext .cjs,.js,.jsx,.ts,.tsx --cache .",
"lint-fix": "prettier --write \"**/*.{ts,tsx,js,jsx,cjs}\" && npm run lint",
"lint:staged": "lint-staged -q"
"lint:staged": "lint-staged -q",
"typecheck": "tsc -p ./tsconfig.lint.json"
},
"lint-staged": {
"*.{cjs,js,jsx,ts,tsx}": ["prettier --write", "cross-env NODE_ENV=development eslint --cache"],
Expand Down
10 changes: 8 additions & 2 deletions lib/papi-dts/tsconfig.lint.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
{
"extends": "./tsconfig",
"files": [".eslintrc.cjs", "edit-papi-d-ts.ts", "papi.d.ts"]
"extends": "../../tsconfig",
"compilerOptions": {
"module": "ESNext",
"baseUrl": "./",
"noEmit": true
},
"include": [".eslintrc.cjs", "edit-papi-d-ts.ts", "papi.d.ts"],
"exclude": []
}
2 changes: 1 addition & 1 deletion lib/platform-bible-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "platform-bible-react",
"version": "0.0.1",
"type": "module",
"description": "React components and hooks to use in Platform - packaged to include styles sheets.",
"description": "React components and hooks to use in Paranext - packaged to include styles sheets.",
"license": "MIT",
"homepage": "https://github.com/paranext/paranext-core/tree/main/lib/platform-bible-react",
"bugs": {
Expand Down
2 changes: 1 addition & 1 deletion lib/platform-bible-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "platform-bible-utils",
"version": "0.0.1",
"type": "module",
"description": "Utilities to use in Platform.",
"description": "Utilities to use in Paranext.",
"license": "MIT",
"homepage": "https://github.com/paranext/paranext-core/tree/main/lib/platform-bible-utils",
"bugs": {
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,10 @@
"storybook:build": "storybook build",
"test": "npm run test:core && npm run test --workspaces --if-present",
"test:core": "jest --silent",
"typecheck": "npm run typecheck:core && npm run typecheck:extensions && npm run typecheck:platform-bible-utils && npm run typecheck:platform-bible-react",
"typecheck": "npm run typecheck:core && npm run typecheck:extensions && npm run typecheck:papi-dts && npm run typecheck:platform-bible-utils && npm run typecheck:platform-bible-react",
"typecheck:core": "tsc -p ./tsconfig.lint.json",
"typecheck:extensions": "cd extensions && npm run typecheck",
"typecheck:papi-dts": "cd lib/papi-dts && npm run typecheck",
"typecheck:platform-bible-react": "cd lib/platform-bible-react && npm run typecheck",
"typecheck:platform-bible-utils": "cd lib/platform-bible-utils && npm run typecheck"
},
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@
".erb/dll",
"extensions",
"lib/platform-bible-react",
"lib/platform-bible-utils"
"lib/platform-bible-utils",
"lib/papi-dts"
],
"ts-node": {
"require": ["tsconfig-paths/register"]
Expand Down

0 comments on commit 5075672

Please sign in to comment.