Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix NA scenarios #13

Merged
merged 4 commits into from
Jul 2, 2024
Merged

🐛 Fix NA scenarios #13

merged 4 commits into from
Jul 2, 2024

Conversation

juanesarango
Copy link
Contributor

@juanesarango juanesarango commented Jun 28, 2024 •
edited
Loading

The API has been showing issues:

  • When calculation NRes2 for "Not Assessed"-mutations scenarios.
  • Lack of consistency, some fields options are "NA" others "N/A".
  • TP53maxvaf should be required when TP53mut > 0.
  • Add information about Inferred LOH (issue Return TP53_loh: 1 when it's inferred from TP53mut and TP53maxvaf #14)
  • Fix inconsistencies withe SF3B1alpha conditions when some of the dependent genes is NA.

Fixes issue: #12

@juanesarango juanesarango merged commit 3db47b9 into main Jul 2, 2024
2 checks passed
@juanesarango juanesarango deleted the fix-NA-scenarios branch July 2, 2024 19:20
@juanesarango juanesarango mentioned this pull request Jul 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@juanesarango