Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure mounted installable packages are installed as expected #1016

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

DawoudSheraz
Copy link
Contributor

@DawoudSheraz DawoudSheraz commented Mar 15, 2024

Fixes #997

When xblocks and other installed packages are mounted, they are installed during image build. The dirs are copied over and then pip install takes place (resulting in egg-file generation). However, the dirs are not updated in host directories. When running tutor, the host files are re-mounted at run time. Due to missing egg-info, the installed packages no longer appear in pip list. This PR adds a small step during initialization that runs pip install on the mounted dirs if egg-info is missing.

Testing

@DawoudSheraz DawoudSheraz changed the title fix: ensure mounted xblocks are installed as expected fix: ensure mounted installable packages are installed as expected Mar 15, 2024
Copy link
Contributor

@Danyal-Faheem Danyal-Faheem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
I've tested it out on Tutor version 17.0.2 and it's working perfectly.

Copy link
Contributor

@regisb regisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@regisb regisb merged commit 0e37449 into overhangio:master Mar 21, 2024
1 check passed
@DawoudSheraz DawoudSheraz deleted the dsheraz/tutor#997 branch June 10, 2024 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

tutor mounts add /path-to-openedx-scorm-xblock doesn't automatically install scorm-xblock
3 participants