-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add quince compatibility for distro #57
Conversation
tutordistro/patches/openedx-dev-dockerfile-post-python-requirements
Outdated
Show resolved
Hide resolved
This looked good, but if we install distro with Another feedback with less priority is that we may want to remove the step of adding the private package in the private.txt file and avoid the related sections of the tests. If we can remove that in this PR, it will be amazing, but if not, we don't need to block this PR for that. |
@MaferMazu I refactored the code to fix that problem, please check it out again and let me know if anything else arises |
This looks good so far. Can you add a warning or a message to the PR description that explains that we need tutor v17.0.3 to support enable-private-packages? And remember when we will merge this to put a breaking change that mentions that we needed to change the enable-private-packages to work with quince. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
With these changes, we can install private packages properly and provide support for the quince release. Thanks for this @Asespinel 🙌
Note: I had problems with the themes, but it was because the example said palma.master
for the saas-themes branch, and it's incorrect for this version. Can we change that and add info about why v17.0.3? This is the only feedback I have. Thanks again for this support, Andrés.
Sure thing, I'll add those changes to my description thanks for the advice. |
1a1cf50
to
79dbe16
Compare
…ter understanding
79dbe16
to
19ea4a5
Compare
This PR adds quince compatibility for the distro plugin.
Major changes
How to test