Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all uses of FlintQQ and FlintZZ #4261

Merged
merged 1 commit into from
Nov 6, 2024

Replace all uses of `FlintQQ` and `FlintZZ`

d61d988
Select commit
Loading
Failed to load commit list.
Merged

Replace all uses of FlintQQ and FlintZZ #4261

Replace all uses of `FlintQQ` and `FlintZZ`
d61d988
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 1s

84.60% (-0.01%) compared to 852b6d1

View this Pull Request on Codecov

84.60% (-0.01%) compared to 852b6d1

Details

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (852b6d1) to head (d61d988).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/NumberTheory/NmbThy.jl 12.50% 7 Missing ⚠️
src/Rings/binomial_ideals.jl 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4261      +/-   ##
==========================================
- Coverage   84.60%   84.60%   -0.01%     
==========================================
  Files         640      640              
  Lines       85128    85117      -11     
==========================================
- Hits        72021    72009      -12     
- Misses      13107    13108       +1     
Files with missing lines Coverage Δ
experimental/QuadFormAndIsom/test/runtests.jl 100.00% <100.00%> (ø)
src/NumberTheory/GaloisGrp/GaloisGrp.jl 78.61% <100.00%> (ø)
src/NumberTheory/GaloisGrp/Qt.jl 67.63% <100.00%> (ø)
src/PolyhedralGeometry/solving_integrally.jl 95.45% <ø> (ø)
src/Rings/NumberField.jl 90.16% <100.00%> (ø)
src/Rings/hilbert.jl 61.23% <ø> (ø)
src/Rings/mpoly-graded.jl 91.58% <100.00%> (ø)
src/Rings/binomial_ideals.jl 88.24% <71.42%> (ø)
src/NumberTheory/NmbThy.jl 60.10% <12.50%> (-1.04%) ⬇️

... and 2 files with indirect coverage changes