Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all uses of FlintQQ and FlintZZ #4261

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

lgoettgens
Copy link
Member

Some preparation for Nemocas/Nemo.jl#1935

@joschmitt
Copy link
Member

Out of interest: I was raised with the believe that there is a difference between QQ and FlintQQ and that one should prefer FlintQQ. Did this change? (Was it just in Hecke but not in OSCAR?)

@lgoettgens
Copy link
Member Author

Out of interest: I was raised with the believe that there is a difference between QQ and FlintQQ and that one should prefer FlintQQ. Did this change? (Was it just in Hecke but not in OSCAR?)

Maybe back in the time QQ referred to AbstractAlgebra.QQ (ie BigInt)? I am way too young for things like this

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (852b6d1) to head (d61d988).
Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/NumberTheory/NmbThy.jl 12.50% 7 Missing ⚠️
src/Rings/binomial_ideals.jl 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4261      +/-   ##
==========================================
- Coverage   84.60%   84.60%   -0.01%     
==========================================
  Files         640      640              
  Lines       85128    85117      -11     
==========================================
- Hits        72021    72009      -12     
- Misses      13107    13108       +1     
Files with missing lines Coverage Δ
experimental/QuadFormAndIsom/test/runtests.jl 100.00% <100.00%> (ø)
src/NumberTheory/GaloisGrp/GaloisGrp.jl 78.61% <100.00%> (ø)
src/NumberTheory/GaloisGrp/Qt.jl 67.63% <100.00%> (ø)
src/PolyhedralGeometry/solving_integrally.jl 95.45% <ø> (ø)
src/Rings/NumberField.jl 90.16% <100.00%> (ø)
src/Rings/hilbert.jl 61.23% <ø> (ø)
src/Rings/mpoly-graded.jl 91.58% <100.00%> (ø)
src/Rings/binomial_ideals.jl 88.24% <71.42%> (ø)
src/NumberTheory/NmbThy.jl 60.10% <12.50%> (-1.04%) ⬇️

... and 2 files with indirect coverage changes

@lgoettgens
Copy link
Member Author

Triage decided this is the way to go (ref #1379 (comment))

@fingolfin fingolfin merged commit 309dcf7 into oscar-system:master Nov 6, 2024
29 checks passed
@lgoettgens lgoettgens deleted the lg/FlintQQ-ZZ branch November 25, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants