bib: add support for the new Disk customizations #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pyflake is unhappy: |
|
FWIW, I tested this PR myself and it all works well. I'm good to merge to get the feature in people's hands and we can add an integration test later. |
achilleas-k
force-pushed
the
use-new-disk-customizations-no-integration-test-yet
branch
from
60169e7
to
ed60e4c
Compare
|
Fixed the linting issue and amended. |
This commit makes use of the excellent work in osbuild/images#1041 and wires up support to generate LVM and btrfs volumes via the new disk customizations. It also add tests.
achilleas-k
force-pushed
the
use-new-disk-customizations-no-integration-test-yet
branch
from
ed60e4c
to
1ddd447
Compare
achilleas-k
approved these changes
Nov 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Flake on the merge queue. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I guess it's not a flake. |
This was referenced Nov 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new Disk customizations from osbuild/images#1041 into bib.
Split from #721 to allow people to experiment easier, getting the integration test right is a bit tedious.