Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image: run ValidateLayoutConstraints() when using DiskCustomizations #726

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Nov 25, 2024

[build on top of https://github.com//pull/725, see last commit]

This commit will run ValidateLayoutConstraints() when a DiskCustomization
is used.

Similar comment to osbuild/images#1063:

Fwiw, the fact that we have to implement this in every distro (and in bib) and must not forget about it makes me wonder if we shouldn't flip this around. Call it by default but return a distinct error type (ValidateLayoutConstraintsError) when it is violated that clients (like a potential low-level otk partitioner) could choose to ignore. Wdyt?

This commit makes use of the excellent work in
osbuild/images#1041 and wires up support
to generate LVM and btrfs volumes via the new disk customizations.

It also add tests.
This commit will run ValidateLayoutConstraints() when a `DiskCustomization`
is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant