Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gazebo simulation plug-in for Hesai XT-32 lidar #1

Closed
wants to merge 3 commits into from

Conversation

2b-t
Copy link
Member

@2b-t 2b-t commented Oct 12, 2023

This commit adds the lidar Gazebo simulation plug-in to the URDF of Hesai PandarXT (similar to the Ouster simulation in frontier_description by @mmattamala in ori-drs/frontier_description#9). The ranges are taken from the Pandar XT-32 brochure and user manual.

In order to test it launch the Hesai with the simulation flag set to true $ roslaunch hesai_description view_urdf.launch simulation:=true, launch Gazebo with roslaunch gazebo_ros mud_world.launch and finally spawn the model into Gazebo with $ rosrun gazebo_ros spawn_model -urdf -param /robot_description -model hesai. Finally add the lidar topic in Rviz.

Here a small preview of what this looks like:

HesaiGazebo.mp4

@2b-t 2b-t added the enhancement New feature or request label Oct 12, 2023
@mauricefallon
Copy link
Contributor

@mmattamala : would you mind reviewing and merging these alphasense and hesai PRs for @2b-t ?
It should all be compatible with handheld Frontier and Spot mounted frontier.

@mcamurri might also have an opinion as he has a Frontier.

This is the other one:
ori-drs/alphasense_description#4

@mmattamala
Copy link

@2b-t The simulations works perfectly for me, thanks for putting this together. For the alphasense, I'll write comments directy in ori-drs/alphasense_description#4

@mcamurri
Copy link
Contributor

Looks great, thanks!

Two minor comments (totally optional):

  • I'm not sure why at line 25 the name of the sensor is hesai_pandar_xt-VLP
  • The the name pandar has been removed from the XT product line some time ago. I'm not sure if you want to use this description for all hesai lidars or only the XT product line. In the last case, you might consider removing the pandar name. The mesh is obviously for the XT-32 model only.

@2b-t 2b-t changed the title Add Gazebo simulation plug-in for Hesai PandarXT lidar Add Gazebo simulation plug-in for Hesai XT-32 lidar Oct 18, 2023
@2b-t
Copy link
Member Author

2b-t commented May 3, 2024

Resolved in #3.

@2b-t 2b-t closed this May 3, 2024
@2b-t 2b-t deleted the feature/add-gazebo-plugin branch May 3, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants