Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 702 #759

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix for 702 #759

merged 1 commit into from
Jun 5, 2024

Conversation

pooja1pathak
Copy link
Collaborator

@pooja1pathak pooja1pathak commented Jun 5, 2024

Proposed changes

Added escaping in crate-exporter.py. Fix for #702

Types of changes

What types of changes does your code introduce to the project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance (update of libraries or other dependences)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have run all the existing tests locally (not just those related to my feature) and there are no errors
  • After the last push to the PR branch, I have run the lint script locally and there are no changes to the code base
  • I have updated the RELEASE NOTES
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Copy link
Contributor

github-actions bot commented Jun 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@pooja1pathak
Copy link
Collaborator Author

I have run tests on CircleCI and all tests have passed except test_others. This test is failing because of geocoding.
image

@pooja1pathak pooja1pathak mentioned this pull request Jun 5, 2024
12 tasks
@c0c0n3
Copy link
Member

c0c0n3 commented Jun 5, 2024

@pooja1pathak good stuff, thanks so much!!

@c0c0n3 c0c0n3 merged commit 3ce6ec6 into orchestracities:master Jun 5, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants