-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved TODO in crate-exporter.py #704
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Necravisaketi nice try, but I reckon you've whipped it together a bit too quickly? :-))
""" | ||
Convert the input into a Crate string. | ||
E.g. input ~~~> 'input' | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why delete the docs?
""" | ||
Convert the input into a Crate quoted identifier. | ||
E.g. input ~~~> "input" | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why delete the docs?
v = str(x) # TODO consider escaping? | ||
return f'"{v}"' | ||
|
||
return f'"{x}"' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this going to help? :-)
>>> x = 'howzit"!"'
>>> f'"{x}"'
'"howzit"!""'
whereas the double quotes in x
should've been escaped: "howzit\"!\""
. Or something similar, can't remember offhand what the escape sequence is for Crate...
v = str(x) # TODO consider escaping? | ||
return f"'{v}'" | ||
|
||
return f"'{x}'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is this going to help? :-)
>>> x = "howzit'!'"
>>> f"'{x}'"
"'howzit'!''"
whereas the single quotes in x
should've been escaped: 'howzit\'!\''
. Or something similar, can't remember offhand what the escape sequence is for Crate...
Covered in #759 |
Proposed changes
Resolved TODO in crate-exporter.py #702
Types of changes
What types of changes does your code introduce to the project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...