Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr #132 integration #142

Merged
merged 21 commits into from
Jan 30, 2019
Merged

Pr #132 integration #142

merged 21 commits into from
Jan 30, 2019

Conversation

c0c0n3
Copy link
Member

@c0c0n3 c0c0n3 commented Jan 25, 2019

This PR integrates the fixes to #127 and #129 that @agaldemas kindly contributed.

Points to note:

  1. PR WIP: Support NGSI Structured Value also for Type different from StructuredValue (if they map to that value type) #132 is the initial contribution from @agaldemas: a fix for error : PostalAddress is not a supported NGSI Type ! #127, attributes names and entity type containing '-' are not accepted by crateDB #128 and automatic casting to NGSI data type #129.
  2. Since PR Quote Crate Identifiers #136 already addresses attributes names and entity type containing '-' are not accepted by crateDB #128, this PR only integrates the code @agaldemas contributed for error : PostalAddress is not a supported NGSI Type ! #127 and automatic casting to NGSI data type #129 while discards contributions towards fixing attributes names and entity type containing '-' are not accepted by crateDB #128---for the rationale behind this, refer to PR WIP: Support NGSI Structured Value also for Type different from StructuredValue (if they map to that value type) #132.
  3. This PR should be merged into v0.6rc after merging WIP: Support NGSI Structured Value also for Type different from StructuredValue (if they map to that value type) #132.

agaldemas and others added 19 commits January 11, 2019 13:53
@agaldemas
Update crate.py
7b3902d 
to fix issue with PostalAddress #127 and #129
if attribute is a complex object of unknown type cast it to NGSI_STRUCTURED_VALUE, to store it as object in Crate
not finish, still miss the test of complex attribute
@agaldemas
add function attrValIsStructured()
c675360 
to test if an attribute value is a structured object
@agaldemas
first commit from local dev repo fix syntax error in new function att…
44f6674 
…rValIsStructured
@agaldemas
added function to detect structured value & use it in case of unknown…
6da6049 
… NGSI type
@agaldemas
quote column names to allow "-" char in name
3b91373
@agaldemas
quote of table and columns names in sql queries
1f815cd
@agaldemas
change funtion attrValIsStructured name to _attr_is_structured
e7bf437 
add test function in test_crate.py: test_accept_unknown_ngsi_type
@agaldemas
added reference to issues in new functios
37167b3 
test_accept_unknown_ngsi_type
test_accept_special_chars
@agaldemas
fixed some code climate issues
07d5c28
@agaldemas
fixed fiware-service and fiware-servicepath header ( '-' was missing)
3b00c9a
@agaldemas
quote table name in drop table queries
ce7cb25
@agaldemas
still issue with drop table add quotes
9349497
@agaldemas
issue mkssing quote in _refresh function
ca4f68d
@agaldemas
fix pb in test test_capitals ?
9eddaef
@agaldemas
fix pb in test test_capitals again
df3600f
@agaldemas
fixed issues with columns containing capital characters
8e14b0d 
test_capitals works ok now
remove lower of attribute names to have correct metadata
@agaldemas
restore lowercase for columns names
93f60bd
@c0c0n3
integrate #127 and #129 fixes; get rid of #128 fix.
6b5ed50
@c0c0n3
Merge branch 'agaldemas-master' into pr#132-integration
37a8138
@c0c0n3 c0c0n3 mentioned this pull request Jan 25, 2019
Merged
@c0c0n3 c0c0n3 requested a review from taliaga January 28, 2019 14:57
c0c0n3
c0c0n3 commented Jan 28, 2019
View reviewed changes
specification/quantumleap.yml Outdated Show resolved Hide resolved
specification/quantumleap.yml Outdated Show resolved Hide resolved
src/translators/tests/test_crate.py Show resolved Hide resolved
src/translators/crate.py Show resolved Hide resolved
src/translators/crate.py Outdated Show resolved Hide resolved
@c0c0n3 c0c0n3 mentioned this pull request Jan 29, 2019
Open
@c0c0n3 c0c0n3 self-assigned this Jan 30, 2019
@c0c0n3 c0c0n3 added this to the 0.6 milestone Jan 30, 2019
@c0c0n3 c0c0n3 mentioned this pull request Jan 30, 2019
Open
@c0c0n3
Copy link
Member Author

c0c0n3 commented Jan 30, 2019

@taliaga as agreed earlier, I added a test case and opened a separate issue to review translation logic. We can merge this PR into 0.6.rc instead of bringing in #144 which would make the tests pass. Will merge as soon as @taliaga approves.

@c0c0n3 c0c0n3 changed the base branch from fix-128 to v0.6rc January 30, 2019 15:34
@c0c0n3 c0c0n3 changed the base branch from v0.6rc to fix-128 January 30, 2019 15:35
@c0c0n3 c0c0n3 merged commit d9ff50b into fix-128 Jan 30, 2019
@c0c0n3
Copy link
Member Author

c0c0n3 commented Jan 30, 2019

Closes #127, #129.

This was referenced Jan 30, 2019
Closed
Closed
@c0c0n3 c0c0n3 deleted the pr#132-integration branch January 30, 2019 17:07
@c0c0n3 c0c0n3 mentioned this pull request Jan 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chicco785 chicco785 chicco785 left review comments

@taliaga taliaga Awaiting requested review from taliaga

Assignees

@c0c0n3 c0c0n3

Labels
None yet
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@c0c0n3 @chicco785 @agaldemas