WIP: Support NGSI Structured Value also for Type different from StructuredValue (if they map to that value type) #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to fix issue with PostalAddress orchestracities#127 and orchestracities#129 if attribute is a complex object of unknown type cast it to NGSI_STRUCTURED_VALUE, to store it as object in Crate not finish, still miss the test of complex attribute
|
Hello here is the pull request, waiting for your advice for the complex attribute test |
chicco785
reviewed
Jan 11, 2019
chicco785
suggested changes
Jan 11, 2019
chicco785
changed the title
agaldemas
changed the title
to test if an attribute value is a structured object
|
@agaldemas, fyi failure in the test is not related to your code, @taliaga what should we do about this painful geolocation issues? |
|
I should work on the PR, during this week. |
add test function in test_crate.py: test_accept_unknown_ngsi_type
test_accept_unknown_ngsi_type test_accept_special_chars
test_capitals works ok now remove lower of attribute names to have correct metadata
|
Rectification, I will restore the lower case for column names, it will be better for existing database, to avoid regression ;O) |
|
Hi guys, I've just realised that #136 overlaps with some of the work done here---namely quoting of identifiers. Merging is going to be a bit painful, but @taliaga and I will try to get it done. @agaldemas thank you so much for your contributions!!! |
Merged
|
You're welcome ! |
Merged
|
follow-up: see PR #142. |
Closed
c0c0n3
added a commit
that referenced
this pull request
Jan 30, 2019
* Update crate.py to fix issue with PostalAddress #127 and #129 if attribute is a complex object of unknown type cast it to NGSI_STRUCTURED_VALUE, to store it as object in Crate not finish, still miss the test of complex attribute * add function attrValIsStructured() to test if an attribute value is a structured object * first commit from local dev repo fix syntax error in new function attrValIsStructured * added function to detect structured value & use it in case of unknown NGSI type * quote column names to allow "-" char in name * quote of table and columns names in sql queries * change funtion attrValIsStructured name to _attr_is_structured add test function in test_crate.py: test_accept_unknown_ngsi_type * added reference to issues in new functios test_accept_unknown_ngsi_type test_accept_special_chars * fixed some code climate issues * fixed fiware-service and fiware-servicepath header ( '-' was missing) * quote table name in drop table queries * still issue with drop table add quotes * issue mkssing quote in _refresh function * fix pb in test test_capitals ? * fix pb in test test_capitals again * fixed issues with columns containing capital characters test_capitals works ok now remove lower of attribute names to have correct metadata * restore lowercase for columns names * rolling back fiware header rename, see #148 * turn comment about empty attr into test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix issue with PostalAddress #127 and #129
if attribute is a complex object of unknown type cast it to NGSI_STRUCTURED_VALUE, to store it as object in Crate
not finish, still miss the test of complex attribute, welcome hints on this and metadata handling