Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: 📖 (doc): Add a doc as a guidance to help users know how to consume the metrics and integrate it with other solutions #1524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Dec 13, 2024

  • Improved Metrics Consumption Documentation:
    • Added a comprehensive guide for consuming metrics exposed by Operator-Controller and CatalogD services.
    • Detailed steps to enable metrics, validate access using curl, and integrate securely with Prometheus Operator using ServiceMonitor

@camilamacedo86 camilamacedo86 requested a review from a team as a code owner December 13, 2024 22:39
Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for olmv1 failed.

Name Link
🔨 Latest commit bdda0de
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6769bc1229cd9300087b7ec3

@camilamacedo86 camilamacedo86 changed the title ⚠️ remove prometheus manifests 🐛 Improving Security: Removing Unused Manifests for Prometheus Dec 13, 2024
@camilamacedo86 camilamacedo86 force-pushed the remove-monitor-prometheues branch from bac6ff6 to 3b00bd8 Compare December 13, 2024 22:45
@camilamacedo86 camilamacedo86 changed the title 🐛 Improving Security: Removing Unused Manifests for Prometheus 🐛 (fix) Removing Unused and Insecure Manifests for Prometheus Dec 13, 2024
@camilamacedo86 camilamacedo86 force-pushed the remove-monitor-prometheues branch from 3b00bd8 to 85f94da Compare December 13, 2024 22:46
@camilamacedo86
Copy link
Contributor Author

/hold

Just to ensure that we all convey

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.25%. Comparing base (10f0f77) to head (e7556e3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1524   +/-   ##
=======================================
  Coverage   74.25%   74.25%           
=======================================
  Files          42       42           
  Lines        3329     3329           
=======================================
  Hits         2472     2472           
  Misses        676      676           
  Partials      181      181           
Flag Coverage Δ
e2e 52.11% <ø> (ø)
unit 56.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bentito
Copy link
Contributor

bentito commented Dec 16, 2024

We should probably be proposing to fix this, if needed, not remove it, since via Prometheus is the primary way people would likely want to monitor metrics for op-con doing its work.

@camilamacedo86
Copy link
Contributor Author

Hi @bentito

I think the best approach might be:

  • a) remove it since we do not support the integration now
  • b) Create an epic for us to do an RFC to know how we will support it.
  • We need to discuss how we do it with the install script, etc. and let it follow the priority list

WDYT?

@bentito

This comment was marked as resolved.

@camilamacedo86 camilamacedo86 force-pushed the remove-monitor-prometheues branch from 85f94da to 23cc069 Compare December 16, 2024 19:47
@tmshort
Copy link
Contributor

tmshort commented Dec 17, 2024

Could we move a fixed monitor.yaml to documents, rather than deleting it?

@joelanford
Copy link
Member

Could we move a fixed monitor.yaml to documents, rather than deleting it?

Not opposed, but we need to be careful about how we do this because our service names are not part of our public API and may change at any time. If we were the ones managing the ServiceMonitor, we could make sure that it was updated appropriately if/when we change our service names. By documenting it, we may inadvertently put the service name and namespace in our public API, which IMO requires a MUCH bigger discussion.

@camilamacedo86 camilamacedo86 force-pushed the remove-monitor-prometheues branch from 23cc069 to cbdc3a7 Compare December 18, 2024 10:52
@camilamacedo86 camilamacedo86 changed the title 🐛 (fix) Removing Unused and Insecure Manifests for Prometheus 🐛 (fix/doc): add metrics consumption guide and remove unsafe configurations Dec 18, 2024
@camilamacedo86
Copy link
Contributor Author

/hold cancel

It seems reasonable to get merged now.
All suggestions are done
And in the community meeting on Dec 17, we discussed it and we agreed to remove the unused and unsafe config

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@camilamacedo86
Copy link
Contributor Author

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@camilamacedo86
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@@ -0,0 +1,254 @@
# Consuming Metrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something we haven't really talked about or established a community-wide standard around: If something is not part of our public API, should we document it? If so, how and where?

As soon as something is documented, it is not unreasonable for consumers to believe it is part of the public API, so we need to be extremely careful about documenting things that fall outside that.

Metrics are not included in our public API. So the above question is very relevant to this PR.

Do we have any prior art here? @michaelryanpeter , what is your stance on how to handle this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During the review about remove the manufests, it was mentioned that we need to create documentation. To address this, I’ve prepared a draft for discussion before we invest more time into it.

The idea is to align on expectations—what should or shouldn’t be included—before proceeding further.

Here’s what we need to clarify:

  1. Should we include details on how to consume the metrics generally?
  2. Or should we focus solely on consuming metrics via Prometheus?

If we choose the option 2, it might result in incomplete or uneven information.

Let’s discuss and agree on the direction before diving deeper into this.

Looking forward to your thoughts!

c/c @tmshort @tylerslaton @michaelryanpeter

trgeiger

This comment was marked as outdated.

@camilamacedo86

This comment was marked as outdated.

@camilamacedo86 camilamacedo86 changed the title 🐛 (fix/doc): add metrics consumption guide and remove unsafe configurations WIP - 🐛 (fix/doc): add metrics consumption guide and remove unsafe configurations Dec 23, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2024
@camilamacedo86 camilamacedo86 force-pushed the remove-monitor-prometheues branch 3 times, most recently from 0f0da4c to bdda0de Compare December 23, 2024 19:37
@camilamacedo86 camilamacedo86 changed the title WIP - 🐛 (fix/doc): add metrics consumption guide and remove unsafe configurations (doc): Add a doc as a guidance to help users know how to consume the metrics and integrate it with other solutions Dec 23, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2024
@camilamacedo86 camilamacedo86 changed the title (doc): Add a doc as a guidance to help users know how to consume the metrics and integrate it with other solutions 📖 (doc): Add a doc as a guidance to help users know how to consume the metrics and integrate it with other solutions Dec 23, 2024
…metrics and integrate it with other solutions
@camilamacedo86 camilamacedo86 force-pushed the remove-monitor-prometheues branch from bdda0de to e7556e3 Compare December 23, 2024 19:40
# Consuming Metrics

> The information provided here is intended as general guidance and does not constitute a guaranteed or officially supported solution.
> Please note that integration with the Prometheus Operator or other third-party tools may have limitations and might not be fully supported.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camilamacedo86 camilamacedo86 changed the title 📖 (doc): Add a doc as a guidance to help users know how to consume the metrics and integrate it with other solutions WIP: 📖 (doc): Add a doc as a guidance to help users know how to consume the metrics and integrate it with other solutions Dec 23, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants