-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: 📖 (doc): Add a doc as a guidance to help users know how to consume the metrics and integrate it with other solutions #1524
base: main
Are you sure you want to change the base?
Conversation
camilamacedo86
commented
Dec 13, 2024
•
edited
Loading
edited
- Improved Metrics Consumption Documentation:
- Added a comprehensive guide for consuming metrics exposed by Operator-Controller and CatalogD services.
- Detailed steps to enable metrics, validate access using curl, and integrate securely with Prometheus Operator using ServiceMonitor
❌ Deploy Preview for olmv1 failed.
|
bac6ff6
to
3b00bd8
Compare
3b00bd8
to
85f94da
Compare
/hold Just to ensure that we all convey |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1524 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 42 42
Lines 3329 3329
=======================================
Hits 2472 2472
Misses 676 676
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
We should probably be proposing to fix this, if needed, not remove it, since via Prometheus is the primary way people would likely want to monitor metrics for op-con doing its work. |
Hi @bentito I think the best approach might be:
WDYT? |
This comment was marked as resolved.
This comment was marked as resolved.
85f94da
to
23cc069
Compare
Could we move a fixed |
Not opposed, but we need to be careful about how we do this because our service names are not part of our public API and may change at any time. If we were the ones managing the ServiceMonitor, we could make sure that it was updated appropriately if/when we change our service names. By documenting it, we may inadvertently put the service name and namespace in our public API, which IMO requires a MUCH bigger discussion. |
23cc069
to
cbdc3a7
Compare
/hold cancel It seems reasonable to get merged now. |
I adding Because we need to merge
First due the doc added |
/hold cancel |
docs/howto/how-to-consume-metrics.md
Outdated
@@ -0,0 +1,254 @@ | |||
# Consuming Metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something we haven't really talked about or established a community-wide standard around: If something is not part of our public API, should we document it? If so, how and where?
As soon as something is documented, it is not unreasonable for consumers to believe it is part of the public API, so we need to be extremely careful about documenting things that fall outside that.
Metrics are not included in our public API. So the above question is very relevant to this PR.
Do we have any prior art here? @michaelryanpeter , what is your stance on how to handle this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During the review about remove the manufests, it was mentioned that we need to create documentation. To address this, I’ve prepared a draft for discussion before we invest more time into it.
The idea is to align on expectations—what should or shouldn’t be included—before proceeding further.
Here’s what we need to clarify:
- Should we include details on how to consume the metrics generally?
- Or should we focus solely on consuming metrics via Prometheus?
If we choose the option 2, it might result in incomplete or uneven information.
Let’s discuss and agree on the direction before diving deeper into this.
Looking forward to your thoughts!
This comment was marked as outdated.
This comment was marked as outdated.
0f0da4c
to
bdda0de
Compare
…metrics and integrate it with other solutions
bdda0de
to
e7556e3
Compare
# Consuming Metrics | ||
|
||
> The information provided here is intended as general guidance and does not constitute a guaranteed or officially supported solution. | ||
> Please note that integration with the Prometheus Operator or other third-party tools may have limitations and might not be fully supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelryanpeter ^ wdyt