Skip to content

Commit

Permalink
(fix) Removing Unused and Insecure Manifests for Prometheus since its…
Browse files Browse the repository at this point in the history
… integration is not supported

We are not using these manifests or supporting this option. Therefore, they should be removed, as they are not configured to use certificates and have insecureSkipVerify: false, which promotes an insecure setup by default.

If we want enable this option then we need configure it with:

```yaml
apiVersion: monitoring.coreos.com/v1
kind: ServiceMonitor
metadata:
  labels:
    control-plane: operator-controller-controller-manager
  name: controller-manager-metrics-monitor
  namespace: system
spec:
  endpoints:
    - path: /metrics
      port: https
      scheme: https
      bearerTokenFile: /var/run/secrets/kubernetes.io/serviceaccount/token
      tlsConfig:
        insecureSkipVerify: false
        ca:
          secret:
            name: olmv1-cert
            key: ca.crt
        cert:
          secret:
            name: olmv1-cert
            key: tls.cert
        keySecret:
          name: olmv1-cert
          key: tls.key
  selector:
    matchLabels:
      control-plane: operator-controller-controller-manager
```
  • Loading branch information
camilamacedo86 committed Dec 16, 2024
1 parent 61fe142 commit 23cc069
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 23 deletions.
3 changes: 1 addition & 2 deletions config/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,4 @@ resources:
- crd
- rbac
- manager
# [PROMETHEUS] To enable prometheus monitor, uncomment all sections with 'PROMETHEUS'.
#- ../prometheus

2 changes: 0 additions & 2 deletions config/base/prometheus/kustomization.yaml

This file was deleted.

19 changes: 0 additions & 19 deletions config/base/prometheus/monitor.yaml

This file was deleted.

0 comments on commit 23cc069

Please sign in to comment.