Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply some fixes to WDL examples #689

Open
wants to merge 4 commits into
base: wdl-1.1.3
Choose a base branch
from

Conversation

stxue1
Copy link
Collaborator

@stxue1 stxue1 commented Nov 1, 2024

These are fixes for some of the comments I left at #669

I'm merging into wdl-1.1.3 instead so the eventual merge into wdl-1.1 by #669 will be cleaner.

There are only two tests left that don't work: hisat2 and gatk_haplotype_caller. I haven't look at them yet as I don't have much experience with running the hisat2 or gatk pipeline.

Other than those two, I believe the rest of the examples work.

Checklist

  • Pull request details were added to CHANGELOG.md
  • Valid examples WDL's were added or updated to the SPEC.md (see the guide on writing markdown tests)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant