Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WDL unit tests to CI #5110

Merged
merged 19 commits into from
Nov 5, 2024
Merged

Add WDL unit tests to CI #5110

merged 19 commits into from
Nov 5, 2024

Conversation

stxue1
Copy link
Contributor

@stxue1 stxue1 commented Oct 1, 2024

Resolves #5109
Resolves #4941
Also makes the test_giraffe WDL test run with --logDebug so next time it fails similar to here it will give a more detailed answer. I think it is just a networking issues though, as mentioned here.

Also updates the commit to the branch here DataBiosphere/wdl-conformance-tests#46 (one of the arguments wasn't previously working, which that PR fixes.)

Changelog Entry

To be copied to the draft changelog by merger:

  • Added WDL unit tests to CI

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@adamnovak adamnovak self-requested a review October 9, 2024 17:12
Copy link
Member

@adamnovak adamnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some comments that I think need to be more specific, and it looks like we might not be properly handling failure from one of the test setup scripts.

src/toil/test/wdl/wdltoil_test.py Outdated Show resolved Hide resolved
src/toil/test/wdl/wdltoil_test.py Outdated Show resolved Hide resolved
src/toil/test/wdl/wdltoil_test.py Show resolved Hide resolved
src/toil/test/wdl/wdltoil_test.py Show resolved Hide resolved
@adamnovak
Copy link
Member

This should fix #4941.

@adamnovak
Copy link
Member

It looks like CachingFileStoreTestWithAwsJobStore.testReadCacheMissFileFromJobStoreWithoutCachingReadFile failed because the testing machine lost Internet connectivity to AWS while the test was running.

@stxue1 stxue1 enabled auto-merge (squash) November 5, 2024 01:35
@stxue1 stxue1 merged commit f71dc86 into master Nov 5, 2024
1 check passed
@stxue1 stxue1 deleted the issues/5109-wdl-unit-ci branch November 5, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add WDL unit tests to CI Run wdl-tests, and add it to Toil CI
3 participants