-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new oca branding #1320
Open
fc-santos
wants to merge
26
commits into
openwallet-foundation:main
Choose a base branch
from
MCN-ING:feat/add-new-oca-branding
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,680
−458
Open
Changes from 9 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
72a8ca2
feat: add new oca branding
fc-santos f765c4a
Merge branch 'main' into feat/add-new-oca-branding
fc-santos 2b5444c
Merge branch 'main' into feat/add-new-oca-branding
fc-santos 5459d9c
WIP: work started on new CredentialCard for Branding 1.1
fc-santos 753d44f
wip: work on new brandingOverlay (1.1)
fc-santos eaa4843
Merge branch 'main' into feat/add-new-oca-branding
fc-santos c87a97a
feat: work on new oca branding
fc-santos bceffd9
Merge branch 'main' into feat/add-new-oca-branding
fc-santos b2d1671
Merge branch 'main' into feat/add-new-oca-branding
fc-santos a40504a
refactor: work on duplicated code in CredentialCard12
fc-santos ff9c6a9
Merge branch 'main' into feat/add-new-oca-branding
fc-santos ccc706a
Merge branch 'main' into feat/add-new-oca-branding
fc-santos 11960be
refactor: fix sonarcloud error for hook useParseAttribute
fc-santos 6faad26
refactor: move credential card logo
fc-santos 3a585de
fix: reliability rating sonarcloud
fc-santos 0326595
refactor: move credential card status
fc-santos aa294eb
fix: sonarcloud code duplication
fc-santos c2b4322
refactor: move code
fc-santos 53a70dd
fix: multiple import react-native
fc-santos de489cb
test: update snapshots
fc-santos ef5ff39
feat: update RecordLoading skeleton to display the new branding
fc-santos 883122b
Merge branch 'main' into feat/add-new-oca-branding
fc-santos 9bafc02
Merge branch 'main' into feat/add-new-oca-branding
fc-santos f5a9b7d
Merge branch 'main' into feat/add-new-oca-branding
fc-santos 81efdf5
Merge branch 'main' into feat/add-new-oca-branding
fc-santos 0148d7e
fix: make import relative in notification hook
fc-santos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this PR is still in draft but will it eventually have a
BrandingOverlayType.Branding12
and use that here, rather than use the 12 card with the 11 overlay type?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could do some refactor here @bryce-mcmath but in the oca package there is the Branding01, Branding10 and Branding11. The bifold component that implements each one of these are CredentialCard10 (For the legacy branding), CredentialCard11 (Branding10) and now CredentialCard12 (Branding11).
I'm not sure why the components were not named respectively CredentialCard01, CredentialCard10 in the beginning (maybe due to lint reasons). Maybe we could name them:
Legacy -> CredentialCard01
Branding 1.0 -> CredentialCard10
Branding 1.1 -> CredentialCard11
Let me know what you think. Thanks!