feat: add new oca branding #1320
Conversation
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
| } | ||
|
|
||
| if (credential) { | ||
| if (type === BrandingOverlayType.Branding01) { | ||
| return <CredentialCard10 credential={credential as CredentialExchangeRecord} style={style} onPress={onPress} /> | ||
| } else if (type == BrandingOverlayType.Branding11) { |
There was a problem hiding this comment.
I know this PR is still in draft but will it eventually have a BrandingOverlayType.Branding12 and use that here, rather than use the 12 card with the 11 overlay type?
There was a problem hiding this comment.
I could do some refactor here @bryce-mcmath but in the oca package there is the Branding01, Branding10 and Branding11. The bifold component that implements each one of these are CredentialCard10 (For the legacy branding), CredentialCard11 (Branding10) and now CredentialCard12 (Branding11).
I'm not sure why the components were not named respectively CredentialCard01, CredentialCard10 in the beginning (maybe due to lint reasons). Maybe we could name them:
Legacy -> CredentialCard01
Branding 1.0 -> CredentialCard10
Branding 1.1 -> CredentialCard11
Let me know what you think. Thanks!
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
Signed-off-by: fc-santos <[email protected]>
|
There was a problem hiding this comment.
Are the RFCs being updated?
https://hyperledger.github.io/aries-rfcs/latest/features/0755-oca-for-aries/
https://hyperledger.github.io/aries-rfcs/latest/features/0756-oca-for-aries-style-guide/
The version should align with the Aries RFCs
|
It looks like only the style guide RFC will need to be updated. It'll need to be updated to include this other rendering of the OCA bundle as the this new rendering uses the same OCA bundles, but only lays it out differently. |
|
@fc-santos Can we have a discussion about this PR. Reach out in discord or slack if you have my connection |
Summary of Changes
This PR adds a new BrandingOverlayType.Branding11. The default branding is still the BrandingOverlayType.Branding10. Here what the new branding looks like:
When there is an OCA bundle:
No OCA bundle:
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-byline (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.