Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: example+sd-jwt default typ value plus small linting #10

Merged
merged 2 commits into from
Oct 27, 2023
Merged

feat: example+sd-jwt default typ value plus small linting #10

merged 2 commits into from
Oct 27, 2023

Conversation

peppelinux
Copy link
Member

@peppelinux peppelinux commented Oct 10, 2023 •
edited
Loading

This PR:

  • [Unit Tests] sets the JWS header parameter typ to testcase+sd-jwt
  • default typ configurable also via ENV var SD_JWT_HEADER
  • adds some small code linting
  • sets the version to 0.10.0

@peppelinux peppelinux mentioned this pull request Oct 11, 2023
Closed
danielfett
danielfett requested changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@danielfett danielfett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR! I think we should have a sensible default instead of None, but otherwise this looks good to me.

src/sd_jwt/bin/generate.py Outdated Show resolved Hide resolved
src/sd_jwt/common.py Outdated Show resolved Hide resolved
tests/test_disclose_all_shortcut.py Outdated Show resolved Hide resolved
tests/test_e2e_testcases.py Outdated Show resolved Hide resolved
tests/test_disclose_all_shortcut.py Outdated Show resolved Hide resolved
tests/test_e2e_testcases.py Outdated Show resolved Hide resolved
@danielfett
Copy link
Contributor

Also it looks like the commits are missing the developer sign-off.

@peppelinux peppelinux force-pushed the ph branch 3 times, most recently from 0da42db to ac2e12e Compare October 27, 2023 09:30
@peppelinux peppelinux changed the title feat: sd+jwt is the default typ value in the JWS header. Small linting as well. feat: example+sd-jwt default typ value plus small linting Oct 27, 2023
@peppelinux peppelinux requested a review from danielfett October 27, 2023 09:44
@danielfett danielfett merged commit 956dc43 into openwallet-foundation-labs:main Oct 27, 2023
4 checks passed
@bc-pi bc-pi mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfett danielfett danielfett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peppelinux @danielfett