Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typ:example+sd-jwt everywhere? #365

Closed
bc-pi opened this issue Nov 3, 2023 · 3 comments
Closed

typ:example+sd-jwt everywhere? #365

bc-pi opened this issue Nov 3, 2023 · 3 comments

Comments

@bc-pi
Copy link
Collaborator

bc-pi commented Nov 3, 2023

Do we want the header "typ":"example+sd-jwt" in every example? I'm honestly not sure but wanted to ask b/c that looks like it's going to be the result from openwallet-foundation-labs/sd-jwt-python#10 upstream.

@danielfett
Copy link
Member

We should make a conscious decision about this, especially regarding the examples in the appendix.

@Sakurann
Copy link
Collaborator

Sakurann commented Dec 11, 2023

for example 4a, it must be vc+sd-jwt because it is required by sd-jwt vc spec here.
For example 4b, it should be vc+ld+json+sd-jwt, but it can also be kept example+sd-jwt. because W3C vc-jose-cose spec says The typ header parameter SHOULD be vc+ld+json+sd-jwt..

danielfett added a commit that referenced this issue Dec 11, 2023
bc-pi pushed a commit that referenced this issue Dec 11, 2023
* Fix Issue #365

* Update reference
@bc-pi
Copy link
Collaborator Author

bc-pi commented Feb 13, 2024

good with the state of things currently for typ values

@bc-pi bc-pi closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants