-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve cancellation of large response in TransModel API #5908
Improve cancellation of large response in TransModel API #5908
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-2.x #5908 +/- ##
=============================================
- Coverage 69.45% 69.45% -0.01%
- Complexity 17064 17069 +5
=============================================
Files 1927 1929 +2
Lines 73578 73584 +6
Branches 7549 7550 +1
=============================================
+ Hits 51106 51107 +1
- Misses 19847 19852 +5
Partials 2625 2625 ☔ View full report in Codecov by Sentry. |
f81fa32
to
44c79dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few translation changes.
Summary
#5883 implemented support for cancelling queries that produce too large responses.
However GraphQL resolvers were not properly canceled, as in the case of an API timeout exception.
This PR applies the same logic for large response and API timeout.
Both error cases are mapped to the same HTTP error code (422 - Unprocessable Content) since the root cause is identical: a syntactically correct request that uses too much resources.
Note: multilingual error messages should be updated.
Response sent to the API client:
Issue
No
Unit tests
Added unit tests
Documentation
No