-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zuul job to validate watcher deployment #9
Zuul job to validate watcher deployment #9
Conversation
Skipping CI for Draft Pull Request. |
Zuul encountered a syntax error while parsing its Invalid Ansible variable name '_watcher_repo' for dictionary value @ data['vars'] The problem appears in the the "watcher-operator-base" job stanza: job: in "openstack-k8s-operators/watcher-operator/.zuul.yaml@main", line 12 |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/85b54bceb3f043e19e6c75d023bd98b6 ✔️ openstack-meta-content-provider SUCCESS in 37m 31s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/a9fd2b765db446a7aa8c3291f47248fc ✔️ openstack-meta-content-provider SUCCESS in 35m 57s |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/b8f0e6a28c514f4f8d0beb04f6d15f41 ✔️ openstack-meta-content-provider SUCCESS in 1h 25m 25s |
This change depends on a change that failed to merge. Change #11 is needed. |
https://logserver.rdoproject.org/9/9/b8858ecba31c26914ae4831406c6ed0cf380d053/github-check/watcher-operator-validation/e56536c/job-output.txt hit post_failure due to following error:
|
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c50bf6c9f2564aff8a76d7abd7f5feac ✔️ openstack-meta-content-provider SUCCESS in 1h 21m 12s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6cecd21e4fb64c9d91d7278bae91a3e6 ✔️ openstack-meta-content-provider SUCCESS in 1h 20m 51s |
Still failing: https://softwarefactory-project.io/zuul/t/rdoproject.org/build/71f4b6ecc21d401396c976c63c671e29/console#10/0/6/controller for watcher-operator-index pod and here is the list of other pods.
|
watcher-operator is going to shipped as a standalone operator. It is going to be installed via olm seperatly from index image in openstack-operators namespace. when env_ops_images creates operator_images dictionary, it goes over all the pods listed under openstack-operators namespace with label openstack.org/operator-name which does not exists for watcher-operator-index- pod. It fails with following error[1]: ``` The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'openstack.org/operator-name'. 'dict object' has no attribute 'openstack.org/operator-name' ``` This pr excluded the watcher-operator-index- pod to fix the issue. Links: [1]. openstack-k8s-operators/watcher-operator#9 (comment) Signed-off-by: Chandan Kumar <[email protected]>
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/12358ef8df374f29aa8629913ca63fef ✔️ openstack-meta-content-provider SUCCESS in 1h 39m 36s |
watcher-operator is going to shipped as a standalone operator. It is going to be installed via olm seperatly from index image in openstack-operators namespace. when env_ops_images creates operator_images dictionary, it goes over all the pods listed under openstack-operators namespace with label openstack.org/operator-name which does not exists for watcher-operator-index- pod. It fails with following error[1]: ``` The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'openstack.org/operator-name'. 'dict object' has no attribute 'openstack.org/operator-name' ``` This pr excluded the watcher-operator-index- pod to fix the issue. Links: [1]. openstack-k8s-operators/watcher-operator#9 (comment) Signed-off-by: Chandan Kumar <[email protected]>
recheck |
Below are the test results from the job:
Logs of watcher pod deployment
And operator image used from content provider
|
This pr: - Adds watcher-operator-base job from podified-multinode-edpm-deployment-crc-2comp parent. This job will deploy 2 node EDPM deployment and then deploy watcher operator using make targets from watcher-operator repo. - It adds hook to deploy watcher service via ci-framework hook. Depends-On: openstack-k8s-operators#8 Signed-off-by: Chandan Kumar <[email protected]>
watcher-operator is going to shipped as a standalone operator. It is going to be installed via olm seperatly from index image in openstack-operators namespace. when env_ops_images creates operator_images dictionary, it goes over all the pods listed under openstack-operators namespace with label openstack.org/operator-name which does not exists for watcher-operator-index- pod. It fails with following error[1]: ``` The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'openstack.org/operator-name'. 'dict object' has no attribute 'openstack.org/operator-name' ``` This pr excluded the watcher-operator-index- pod to fix the issue. Links: [1]. openstack-k8s-operators/watcher-operator#9 (comment) Signed-off-by: Chandan Kumar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
minor inline comment for consideration and question about actually validating (but for now we should just get this running and add tempest later?)
- watcher-operator-validation | ||
|
||
- job: | ||
name: watcher-operator-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it should never run itself then you could also add abstract but not worth blocking for
cifmw.general.ci_script: | ||
output_dir: "{{ cifmw_basedir }}/artifacts" | ||
chdir: "{{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/watcher-operator" | ||
script: make watcher_deploy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so with this we install but don't actually validate the services yet. so I guess ultimately the plan is to make run_tempest: true ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, correct! We will extend this job to run basic watcher tempest plugin api tests.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marios The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7ec0729
into
openstack-k8s-operators:main
Thanks for the links and the clear explanation! |
This pr:
podified-multinode-edpm-deployment-crc-2comp parent. This job will
deploy 2 node EDPM deployment and then deploy watcher operator using
make targets from watcher-operator repo.
Test Results: #9 (comment)
Depends-On: #11
Depends-On: openstack-k8s-operators/ci-framework#2569