-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude watcher-operator-index- image in env_op_images role #2569
Conversation
Skipping CI for Draft Pull Request. |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c47626ac442e47cfba04ddfa7fb39569 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 19s |
watcher-operator is going to shipped as a standalone operator. It is going to be installed via olm seperatly from index image in openstack-operators namespace. when env_ops_images creates operator_images dictionary, it goes over all the pods listed under openstack-operators namespace with label openstack.org/operator-name which does not exists for watcher-operator-index- pod. It fails with following error[1]: ``` The task includes an option with an undefined variable. The error was: 'dict object' has no attribute 'openstack.org/operator-name'. 'dict object' has no attribute 'openstack.org/operator-name' ``` This pr excluded the watcher-operator-index- pod to fix the issue. Links: [1]. openstack-k8s-operators/watcher-operator#9 (comment) Signed-off-by: Chandan Kumar <[email protected]>
6f6a028
to
61e71b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to extract the filtering logic to a new task looping over a list or excludes but this patch is following the current standard so approving :)
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lewisdenny The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
watcher-operator is going to shipped as a standalone operator. It is going to be installed via olm seperatly from index image in openstack-operators namespace.
when env_ops_images creates operator_images dictionary, it goes over all the pods listed under openstack-operators namespace with label openstack.org/operator-name which does not exists for watcher-operator-index- pod. It fails with following error[1]:
This pr excluded the watcher-operator-index- pod to fix the issue.
watcher-operator-validation zuul job is green.
Links:
[1]. openstack-k8s-operators/watcher-operator#9 (comment)