Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude watcher-operator-index- image in env_op_images role #2569

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

raukadah
Copy link
Contributor

@raukadah raukadah commented Nov 25, 2024

watcher-operator is going to shipped as a standalone operator. It is going to be installed via olm seperatly from index image in openstack-operators namespace.

when env_ops_images creates operator_images dictionary, it goes over all the pods listed under openstack-operators namespace with label openstack.org/operator-name which does not exists for watcher-operator-index- pod. It fails with following error[1]:

The task includes an option with an undefined variable.
The error was: 'dict object' has no attribute 'openstack.org/operator-name'. 'dict object' has no attribute 'openstack.org/operator-name'

This pr excluded the watcher-operator-index- pod to fix the issue.

watcher-operator-validation zuul job is green.

Links:
[1]. openstack-k8s-operators/watcher-operator#9 (comment)

Copy link
Contributor

openshift-ci bot commented Nov 25, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/c47626ac442e47cfba04ddfa7fb39569

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 52m 19s
podified-multinode-edpm-deployment-crc POST_FAILURE in 1h 16m 18s
cifmw-crc-podified-edpm-baremetal POST_FAILURE in 1h 25m 04s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 02s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 33s
✔️ build-push-container-cifmw-client SUCCESS in 37m 04s
✔️ cifmw-molecule-env_op_images SUCCESS in 19m 06s

watcher-operator is going to shipped as a standalone operator.
It is going to be installed via olm seperatly from index image in openstack-operators
namespace.

when env_ops_images creates operator_images dictionary, it goes over all
the pods listed under openstack-operators namespace with label openstack.org/operator-name
which does not exists for watcher-operator-index- pod. It fails with
following error[1]:
```
The task includes an option with an undefined variable.
The error was: 'dict object' has no attribute 'openstack.org/operator-name'. 'dict object' has no attribute 'openstack.org/operator-name'
```

This pr excluded the watcher-operator-index- pod to fix the issue.

Links:
[1]. openstack-k8s-operators/watcher-operator#9 (comment)

Signed-off-by: Chandan Kumar <[email protected]>
@raukadah raukadah marked this pull request as ready for review November 26, 2024 05:35
Copy link
Collaborator

@lewisdenny lewisdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to extract the filtering logic to a new task looping over a list or excludes but this patch is following the current standard so approving :)

/approve

Copy link
Contributor

openshift-ci bot commented Nov 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lewisdenny

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bshewale bshewale added the lgtm label Nov 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit d3f25e8 into main Nov 26, 2024
5 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the watcher_zuul_job branch November 26, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants