Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change scope of test-operator to namespace #264

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lpiwowar
Copy link
Collaborator

Test-operator is currently designed to be a cluster scoped operator. This means it can watch and modify resources across all OCP cluster.

This patch changes the operator to namespace scoped operator. By default it is going to watch only:

  • openstack-test-operator namespace: This is a namespace where we recommend to install the test-operator. Prior to the installation we recommend to create an OperatorGroup with targetNamespaces value set to openstack-test-operator and openstack.

  • openstack: This is a namespace where the openstack controll plane is deployed. Test-operator requires an access to this namespace in order to read openstack specific CMs and Secrets (e.g., clouds.yaml).

Copy link

openshift-ci bot commented Dec 11, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Dec 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lpiwowar lpiwowar force-pushed the namespace-scoped-operator branch 2 times, most recently from 7fd0f3a to ad48997 Compare December 12, 2024 12:30
lpiwowar added a commit to openstack-k8s-operators/ci-framework that referenced this pull request Dec 12, 2024
The test-operator got changed from cluster scoped operator to namespace
scoped operator in this PR [1]. It is now recommended that the
test-operator gets installed in a separate namespace other than the one
where the test pods are spawned.

This patch ensures that:

 - the test-operator gets installed in the openstack-test-operator
   namespace

 - the test-operator spawns test pods in the openstack namespace

[1] openstack-k8s-operators/test-operator#264
@lpiwowar lpiwowar force-pushed the namespace-scoped-operator branch from ad48997 to 2f211b0 Compare December 12, 2024 17:30
lpiwowar added a commit to openstack-k8s-operators/ci-framework that referenced this pull request Dec 12, 2024
The test-operator got changed from cluster scoped operator to namespace
scoped operator in this PR [1]. It is now recommended that the
test-operator gets installed in a separate namespace other than the one
where the test pods are spawned.

This patch ensures that:

 - the test-operator gets installed in the openstack-test-operator
   namespace

 - the test-operator spawns test pods in the openstack namespace

[1] openstack-k8s-operators/test-operator#264
lpiwowar added a commit to openstack-k8s-operators/ci-framework that referenced this pull request Dec 17, 2024
The test-operator got changed from cluster scoped operator to namespace
scoped operator in this PR [1]. It is now recommended that the
test-operator gets installed in a separate namespace other than the one
where the test pods are spawned.

This patch ensures that:

 - the test-operator gets installed in the openstack-test-operator
   namespace

 - the test-operator spawns test pods in the openstack namespace

[1] openstack-k8s-operators/test-operator#264
@lpiwowar lpiwowar force-pushed the namespace-scoped-operator branch from 2f211b0 to 883001d Compare December 18, 2024 12:22
lpiwowar added a commit to openstack-k8s-operators/ci-framework that referenced this pull request Dec 19, 2024
The test-operator got changed from cluster scoped operator to namespace
scoped operator in this PR [1]. It is now recommended that the
test-operator gets installed in a separate namespace other than the one
where the test pods are spawned.

This patch ensures that:

 - the test-operator gets installed in the openstack-test-operator
   namespace

 - the test-operator spawns test pods in the openstack namespace

[1] openstack-k8s-operators/test-operator#264
@lpiwowar
Copy link
Collaborator Author

/test all

Test-operator is currently designed to be a cluster scoped
operator. This means it can watch and modify resources across all
OCP cluster.

This patch changes the operator to namespace scoped operator. By
default it is going to watch only:

  - openstack-test-operator namespace: This is a namespace where
    we recommend to install the test-operator. Prior to the
    installation we recommend to create an OperatorGroup with
    targetNamespaces value set to openstack-test-operator and
    openstack.

  - openstack: This is a namespace where the openstack controll
    plane is deployed. Test-operator requires an access to this
    namespace in order to read openstack specific CMs and Secrets
    (e.g., clouds.yaml).

Depends-On: openstack-k8s-operators/ci-framework#2600
@lpiwowar lpiwowar force-pushed the namespace-scoped-operator branch from 883001d to 81c09bd Compare December 19, 2024 16:04
@lpiwowar
Copy link
Collaborator Author

/test all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant