Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-operator] Move to openstack-test-operator namespace #2600

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[test-operator] Move to openstack-test-operator namespace #2600

wants to merge 1 commit into from
+38 −22

Conversation

lpiwowar
Copy link
Contributor

The test-operator got changed from cluster scoped operator to namespace scoped operator in this PR [1]. It is now recommended that the test-operator gets installed in a separate namespace other than the one where the test pods are spawned.

This patch ensures that:

  • the test-operator gets installed in the openstack-test-operator namespace

  • the test-operator spawns test pods in the openstack namespace

[1] openstack-k8s-operators/test-operator#264

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign viroel for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/ce7fc9baf6b340efbd8148c19c1513f1

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 46m 16s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 44s
✔️ cifmw-multinode-tempest SUCCESS in 1h 53m 59s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 26s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 02s
✔️ build-push-container-cifmw-client SUCCESS in 24m 21s
❌ cifmw-molecule-test_operator FAILURE in 3m 17s

lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Dec 12, 2024
@lpiwowar
Change scope of test-operator to namespace
2f211b0 
Test-operator is currently designed to be a cluster scoped
operator. This means it can watch and modify resources across all
OCP cluster.

This patch changes the operator to namespace scoped operator. By
default it is going to watch only:

  - openstack-test-operator namespace: This is a namespace where
    we recommend to install the test-operator. Prior to the
    installation we recommend to create an OperatorGroup with
    targetNamespaces value set to openstack-test-operator and
    openstack.

  - openstack: This is a namespace where the openstack controll
    plane is deployed. Test-operator requires an access to this
    namespace in order to read openstack specific CMs and Secrets
    (e.g., clouds.yaml).

Depends-On: openstack-k8s-operators/ci-framework#2600
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4743774be90a46c889af1d4fb5e8d7bf

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 23s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 20m 24s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 12s
✔️ cifmw-multinode-tempest SUCCESS in 1h 43m 40s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 00s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 07s
✔️ build-push-container-cifmw-client SUCCESS in 37m 20s
❌ cifmw-molecule-test_operator FAILURE in 3m 08s

@lpiwowar lpiwowar mentioned this pull request Dec 13, 2024
Draft
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/9918fc55b5b24645ad8256fccdb4577a

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 05m 00s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 21m 11s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 10s
✔️ cifmw-multinode-tempest SUCCESS in 1h 43m 12s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 41s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 36s
✔️ build-push-container-cifmw-client SUCCESS in 36m 03s
❌ cifmw-molecule-test_operator FAILURE in 3m 51s

lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Dec 18, 2024
@lpiwowar
Change scope of test-operator to namespace
883001d 
Test-operator is currently designed to be a cluster scoped
operator. This means it can watch and modify resources across all
OCP cluster.

This patch changes the operator to namespace scoped operator. By
default it is going to watch only:

  - openstack-test-operator namespace: This is a namespace where
    we recommend to install the test-operator. Prior to the
    installation we recommend to create an OperatorGroup with
    targetNamespaces value set to openstack-test-operator and
    openstack.

  - openstack: This is a namespace where the openstack controll
    plane is deployed. Test-operator requires an access to this
    namespace in order to read openstack specific CMs and Secrets
    (e.g., clouds.yaml).

Depends-On: openstack-k8s-operators/ci-framework#2600
@lpiwowar
[test-operator] Move to openstack-test-operator namespace
ee2100d 
The test-operator got changed from cluster scoped operator to namespace
scoped operator in this PR [1]. It is now recommended that the
test-operator gets installed in a separate namespace other than the one
where the test pods are spawned.

This patch ensures that:

 - the test-operator gets installed in the openstack-test-operator
   namespace

 - the test-operator spawns test pods in the openstack namespace

[1] openstack-k8s-operators/test-operator#264
lpiwowar added a commit to lpiwowar/test-operator that referenced this pull request Dec 19, 2024
@lpiwowar
Change scope of test-operator to namespace
81c09bd 
Test-operator is currently designed to be a cluster scoped
operator. This means it can watch and modify resources across all
OCP cluster.

This patch changes the operator to namespace scoped operator. By
default it is going to watch only:

  - openstack-test-operator namespace: This is a namespace where
    we recommend to install the test-operator. Prior to the
    installation we recommend to create an OperatorGroup with
    targetNamespaces value set to openstack-test-operator and
    openstack.

  - openstack: This is a namespace where the openstack controll
    plane is deployed. Test-operator requires an access to this
    namespace in order to read openstack specific CMs and Secrets
    (e.g., clouds.yaml).

Depends-On: openstack-k8s-operators/ci-framework#2600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablintino pablintino Awaiting requested review from pablintino pablintino will be requested when the pull request is marked ready for review pablintino is a code owner

@lewisdenny lewisdenny Awaiting requested review from lewisdenny lewisdenny will be requested when the pull request is marked ready for review lewisdenny is a code owner

Assignees
No one assigned
Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lpiwowar