Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIPS support for RabbitMQ #657

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

Akrog
Copy link
Contributor

@Akrog Akrog commented Feb 7, 2024

When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode.

This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO 1.

Jira: #OSPRH-4668
Depends-On: openstack-k8s-operators/lib-common#448

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/8d6a1510303d46669e8c1ffdaa938431

openstack-k8s-operators-content-provider FAILURE in 6m 35s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d955f80cf460448ca874eb31410c058e

openstack-k8s-operators-content-provider FAILURE in 6m 20s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@Akrog Akrog changed the title WIP: FIPS support for RabbitMQ FIPS support for RabbitMQ Mar 7, 2024
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/269fbd1b71bf41668dcdba48f7720567

openstack-k8s-operators-content-provider FAILURE in 6m 13s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-data-plane-adoption-osp-17-to-extracted-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ openstack-operator-tempest-multinode SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be
deployed with specific parameters to also enable its FIPS mode.

This patch checks when OCP is running in FIPS mode using lib-common and
changes the environmental variables used to deploy RabbitMQ just like we
did in TripleO [1].

[1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176

Jira: #OSPRH-4668
Depends-On: openstack-k8s-operators/lib-common#448
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c7b553ee89cd4a6a81357c801ab2f029

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 21s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 13m 50s
openstack-operator-tempest-multinode FAILURE in 1h 25m 49s

@Akrog
Copy link
Contributor Author

Akrog commented Mar 13, 2024

/test rdoproject.org/github-check

Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

@Akrog: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test functional
  • /test images
  • /test openstack-operator-build-deploy
  • /test openstack-operator-build-deploy-kuttl
  • /test precommit-check

The following commands are available to trigger optional jobs:

  • /test openstack-operator-build-deploy-tempest

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openstack-k8s-operators-openstack-operator-main-functional
  • pull-ci-openstack-k8s-operators-openstack-operator-main-images
  • pull-ci-openstack-k8s-operators-openstack-operator-main-openstack-operator-build-deploy-kuttl
  • pull-ci-openstack-k8s-operators-openstack-operator-main-precommit-check

In response to this:

/test rdoproject.org/github-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Akrog
Copy link
Contributor Author

Akrog commented Mar 13, 2024

recheck

Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/bbfbe0087bfd49448e5fd7955d0415e4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 20s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 05m 09s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 14m 46s
openstack-operator-tempest-multinode FAILURE in 1h 19m 10s

Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Akrog, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stuggi
Copy link
Contributor

stuggi commented Mar 14, 2024

ci failure test_live_block_migration_with_attached_volume is unrelated to this change

@stuggi
Copy link
Contributor

stuggi commented Mar 14, 2024

/override rdoproject.org/github-check

Copy link
Contributor

openshift-ci bot commented Mar 14, 2024

@stuggi: Overrode contexts on behalf of stuggi: rdoproject.org/github-check

In response to this:

/override rdoproject.org/github-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 3b435f1 into openstack-k8s-operators:main Mar 14, 2024
7 checks passed
@Akrog Akrog deleted the fips branch March 14, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants