FIPS: Add common/ocp module #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akrog
added a commit
to Akrog/openstack-operator
that referenced
this pull request
Feb 7, 2024
When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode. This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO [1]. [1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176 Depends-On: openstack-k8s-operators/lib-common#448
Akrog
added a commit
to Akrog/openstack-operator
that referenced
this pull request
Feb 7, 2024
When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode. This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO [1]. [1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176 Depends-On: openstack-k8s-operators/lib-common#448
For FIPS support we need to be able to tell when an OCP cluster has been deployed in FIPS mode (it's a day one operation). This patch adds the `IsFipsCluster` function that checks if FIPS is enabled or not. The way to do that is checking the install-config YAML that is stored in the cluster-config-v1 Config Map. If we find the fips key, and it has the true value, then it's deployed in FIPS mode, otherwise it isn't.
Akrog
added a commit
to Akrog/openstack-operator
that referenced
this pull request
Mar 6, 2024
When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode. This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO [1]. [1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176 Depends-On: openstack-k8s-operators/lib-common#448
Akrog
added a commit
to Akrog/openstack-operator
that referenced
this pull request
Mar 7, 2024
When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode. This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO [1]. [1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176 Jira: #OSPRH-4668 Depends-On: openstack-k8s-operators/lib-common#448
Akrog
added a commit
to Akrog/openstack-operator
that referenced
this pull request
Mar 7, 2024
When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode. This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO [1]. [1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176 Jira: #OSPRH-4668 Depends-On: openstack-k8s-operators/lib-common#448
Akrog
added a commit
to Akrog/openstack-operator
that referenced
this pull request
Mar 11, 2024
When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode. This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO [1]. [1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176 Jira: #OSPRH-4668 Depends-On: openstack-k8s-operators/lib-common#448
Akrog
added a commit
to Akrog/openstack-operator
that referenced
this pull request
Mar 13, 2024
When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode. This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO [1]. [1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176 Jira: #OSPRH-4668 Depends-On: openstack-k8s-operators/lib-common#448
stuggi
pushed a commit
to stuggi/openstack-operator
that referenced
this pull request
Apr 9, 2024
When the OCP cluster is deployed in FIPS mode RabbitMQ needs to be deployed with specific parameters to also enable its FIPS mode. This patch checks when OCP is running in FIPS mode using lib-common and changes the environmental variables used to deploy RabbitMQ just like we did in TripleO [1]. [1]: https://opendev.org/openstack/puppet-tripleo/src/commit/019ec495180d2065a172861554df2ba2a76b5b17/manifests/profile/base/rabbitmq.pp#L176 Jira: #OSPRH-4668 Depends-On: openstack-k8s-operators/lib-common#448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FIPS support we need to be able to tell when an OCP cluster has been deployed in FIPS mode (it's a day one operation).
This patch adds the
IsFipsClusterfunction that checks if FIPS is enabled or not.The way to do that is checking the install-config YAML that is stored in the cluster-config-v1 Config Map.
If we find the fips key, and it has the true value, then it's deployed in FIPS mode, otherwise it isn't.
Related patch: openstack-k8s-operators/openstack-operator#657
Jira: #OSPRH-4666