Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump openstack-baremetal-operator #633

Closed
wants to merge 1 commit into from

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Jan 17, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from abays and viroel January 17, 2024 07:42
Copy link
Contributor

openshift-ci bot commented Jan 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rabi
Once this PR has been reviewed and has the lgtm label, please assign lewisdenny for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rabi
Copy link
Contributor Author

rabi commented Jan 17, 2024

/test precommit-check

@rabi
Copy link
Contributor Author

rabi commented Jan 17, 2024

Rebased #627 and will close this if that one merges earlier.

@rabi
Copy link
Contributor Author

rabi commented Jan 17, 2024

recheck

@rabi
Copy link
Contributor Author

rabi commented Jan 17, 2024

/test precommit-check

@dprince
Copy link
Contributor

dprince commented Jan 17, 2024

@rabi wondering what version of golang you are using locally? I'm using go1.19.12 and when I bump the baremetal-operator to the version you have specified here I only see that plus the respective go.sum entries for baremetal-operator get changed. Looks like this PR pulls in some extra stuff.

@rabi
Copy link
Contributor Author

rabi commented Jan 18, 2024

@rabi wondering what version of golang you are using locally?

Hmm. Mine is 1.19.10, not sure how all those extra stuff got in in the PR. Locally I've only the changes to baremetal-operator entries it seems.

@rabi
Copy link
Contributor Author

rabi commented Jan 18, 2024

/test openstack-operator-build-deploy-kuttl

1 similar comment
@rabi
Copy link
Contributor Author

rabi commented Jan 18, 2024

/test openstack-operator-build-deploy-kuttl

@rabi
Copy link
Contributor Author

rabi commented Jan 18, 2024

error: build error: Failed to push image: trying to reuse blob sha256:07a64a71e01156f8f99039bc246149925c6d1480d3957de78510bbec6ec68f7a at destination: pinging container registry quay.rdoproject.org: Get "https://quay.rdoproject.org/v2/": net/http: TLS handshake timeout

@rabi
Copy link
Contributor Author

rabi commented Jan 18, 2024

/test openstack-operator-build-deploy-kuttl

@karelyatin
Copy link
Contributor

the other one #627 approved, so this no longer needed.

@rabi rabi closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants