Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop setting default PROVISIONING_INTERFACE #661

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Drop setting default PROVISIONING_INTERFACE #661

merged 1 commit into from
Jan 19, 2024

Conversation

rabi
Copy link
Contributor

@rabi rabi commented Dec 13, 2023 •
edited
Loading

We use virtualmedia for provisioning now, so it's better to drop setting the PROVISIONING_INTERFACE to avoid confusion.

@openshift-ci openshift-ci bot requested review from dprince and karelyatin December 13, 2023 07:40
@rabi rabi changed the title Drop setting PROVISIONING_INTERFACE Drop setting default PROVISIONING_INTERFACE Dec 13, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9a188b4cfd3c42ce82708d31d4bafe62

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 15m 28s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 1h 01m 15s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 12m 28s
❌ content-provider-data-plane-adoption-OSP-17-to-extracted-crc RETRY_LIMIT in 13m 06s

@rabi rabi force-pushed the provisioning_interface branch from 61e5ed0 to 5e5ef14 Compare December 18, 2023 09:35
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-k8s-operators/install_yamls for 661,5e5ef1489e3721e42015d5ecc8e7ba1671240882

@rabi rabi force-pushed the provisioning_interface branch from 5e5ef14 to 7ab7935 Compare December 18, 2023 09:47
@rabi rabi force-pushed the provisioning_interface branch from 7ab7935 to d6b9400 Compare December 18, 2023 10:18
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/51fc773bd14d48c2a0f19d24dcf5686f

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 14m 47s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 47m 58s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 40s
✔️ content-provider-data-plane-adoption-OSP-17-to-extracted-crc SUCCESS in 1h 59m 39s

@rabi
Copy link
Contributor Author

rabi commented Jan 16, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/53f43b25f2154fa2827559844209bde0

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 45s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 49m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 05s

@rabi
Copy link
Contributor Author

rabi commented Jan 16, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/38fd5cababdb4b099aa4d36467314279

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 24m 52s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 58m 57s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 07m 32s

@abays
Copy link
Contributor

abays commented Jan 16, 2024

recheck

Not sure if this is transient or not, but let's try again:

Unable to connect to http://192.168.126.11:6190/edpm-hardened-uefi.qcow2.sha256, retrying. Error: HTTPConnectionPool(host='192.168.126.11', port=6190): Max retries exceeded with url: /edpm-hardened-uefi.qcow2.sha256

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/4bf5d1653a4849aa9826219c7119f3be

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 27m 50s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 55m 18s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 29s

@rabi
Copy link
Contributor Author

rabi commented Jan 17, 2024

recheck

Not sure if this is transient or not, but let's try again:

Unable to connect to http://192.168.126.11:6190/edpm-hardened-uefi.qcow2.sha256, retrying. Error: HTTPConnectionPool(host='192.168.126.11', port=6190): Max retries exceeded with url: /edpm-hardened-uefi.qcow2.sha256

Looks like crc uses a hardcoded non-routable ip[1] for hostIP, and the ironic agent from the edpm nodes can't reach it.

[1] crc-org/crc#1491

@rabi
Drop setting PROVISIONING_INTERFACE
a285402 
We use virtualmedia for provisioning now, so it's better to drop
setting the PROVISIONING_INTERFACE to avoid confusion.
@rabi rabi force-pushed the provisioning_interface branch from d6b9400 to a285402 Compare January 17, 2024 05:49
@rabi
Copy link
Contributor Author

rabi commented Jan 17, 2024

recheck

@rabi
Copy link
Contributor Author

rabi commented Jan 17, 2024

This works now, but zuul jobs are not reporting back after success. Once that's fixed we can recheck again.

@rabi
Copy link
Contributor Author

rabi commented Jan 17, 2024

recheck

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/20fb0716b0b1482896c3d8275fb47521

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 29s
✔️ install-yamls-crc-podified-edpm-baremetal SUCCESS in 1h 18m 50s
❌ podified-multinode-edpm-deployment-crc FAILURE in 32m 45s

@rabi
Copy link
Contributor Author

rabi commented Jan 18, 2024

recheck the server is currently unable to handle the request (get users.user.openshift.io ~)"

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/aaa897c5805c40d7826e02fcb808b5e4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 16s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 1h 17m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 09m 18s

@rabi
Copy link
Contributor Author

rabi commented Jan 18, 2024

recheck kernel panic

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/5b509b3d397c4b198f27a30c53855aed

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 29m 19s
❌ install-yamls-crc-podified-edpm-baremetal FAILURE in 1h 13m 44s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 11m 31s

@rabi
Copy link
Contributor Author

rabi commented Jan 18, 2024

recheck

@rabi
Copy link
Contributor Author

rabi commented Jan 19, 2024

@abays can we merge this?

abays
abays approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, rabi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b7191cf into openstack-k8s-operators:main Jan 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abays abays abays approved these changes

@dprince dprince Awaiting requested review from dprince

@karelyatin karelyatin Awaiting requested review from karelyatin

Assignees

@abays abays

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rabi @abays @openshift-merge-robot