Ensure nodeSelector logic is consistent for all operators #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to a pointer for nodeSelector to allow different logic for empty vs unset
This was referenced Nov 15, 2024
gibizer
reviewed
Nov 18, 2024
auniyal61
added a commit
to auniyal61/nova-operator
that referenced
this pull request
Nov 18, 2024
Nova operator's dbpurge job should assigned a node Depends-on: openstack-k8s-operators#894 Closes #OSPRH-10765
There is no need drop empty nodeSelector maps, omitempty already does this
gibizer
approved these changes
Nov 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gibizer, olliewalsh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 42b7b84
into
openstack-k8s-operators:main
9 checks passed
auniyal61
added a commit
to auniyal61/nova-operator
that referenced
this pull request
Nov 20, 2024
Nova operator's dbpurge job should assigned a node Depends-on: openstack-k8s-operators#894 Closes #OSPRH-10765
|
/cherry-pick 18.0-fr1 |
|
@olliewalsh: new pull request created: #897 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodeSelectors are not currently applied consistently across all operators.
Some do not support nodeSelectors at all - will be implemented in this series of pull requests.
Some do not apply them to every pod (jobs/cronjobs esp) - will be resolved in this series of pull requests.
Some do not apply a node selector update correctly, only when not initially set.
Some support nodeSelectors but do not inherit the default nodeSelector from the OpenstackControlPlane CR.
Jira: OSPRH-10734