Functional test for dbpurge job #896
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
1 similar comment
|
/retest |
auniyal61
force-pushed
the
test-dbpurge-nodeselector
branch
from
fe3da3d to
7139863
Compare
mrkisaolamb
reviewed
Nov 25, 2024
mrkisaolamb
requested changes
Nov 25, 2024
gibizer
reviewed
Nov 26, 2024
| @@ -376,6 +376,8 @@ var _ = Describe("NovaConductor controller", func() { | |||
| Equal(fmt.Sprintf("%d", *conductor.Spec.DBPurge.ArchiveAge))) | |||
| Expect(GetEnvVarValue(jobEnv, "PURGE_AGE", "")).To( | |||
| Equal(fmt.Sprintf("%d", *conductor.Spec.DBPurge.PurgeAge))) | |||
| nodeSelector := cron.Spec.JobTemplate.Spec.Template.Spec.NodeSelector | |||
| Expect(nodeSelector).NotTo(BeNil()) | |||
There was a problem hiding this comment.
We want to test that the NodeSelector from the NovaConductor Spec is passed to the DB purge job's NodeSelector.
There was a problem hiding this comment.
I believe what Gibi meant was to check if this is the same NodeSelector as in NovaConductorSpec. Please verify and ensure they are identical
auniyal61
force-pushed
the
test-dbpurge-nodeselector
branch
from
7139863 to
a52914c
Compare
Nova operator's dbpurge job should assigned a node Closes #OSPRH-10765
auniyal61
force-pushed
the
test-dbpurge-nodeselector
branch
from
a52914c to
713fa2f
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: auniyal61, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit dfc4cc1
into
openstack-k8s-operators:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nova operator's dbpurge job should assigned a node
Closes #OSPRH-10765