Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role to setup neutron ovn agent #463

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add role to setup neutron ovn agent #463

merged 1 commit into from
Oct 23, 2023

Conversation

karelyatin
Copy link
Contributor

@karelyatin karelyatin commented Oct 18, 2023 •
edited by openshift-ci bot
Loading

This agent is used to provide QoS to hardware offloaded ports on the compute nodes.

Related-Issue: OSP-26191

@openshift-ci openshift-ci bot requested review from jpodivin and lewisdenny October 18, 2023 13:33
karelyatin added a commit to karelyatin/neutron-operator that referenced this pull request Oct 18, 2023
@karelyatin
Create EDP Secret for Neutron OVN Agent
2916bb8 
OVN NB and SB DB connection strings are exported with
this secret as these are required by neutron-ovn-agent[1].

[1] openstack-k8s-operators/edpm-ansible#463
Related-Issue: OSP-26191
@karelyatin karelyatin mentioned this pull request Oct 18, 2023
Merged
karelyatin added a commit to openstack-k8s-operators/dataplane-operator that referenced this pull request Oct 18, 2023
@karelyatin
Add neutron-ovn service to deploy this agent on EDP Nodes
d95c50b 
Depends-On: openstack-k8s-operators/neutron-operator#231
Depends-On: openstack-k8s-operators/edpm-ansible#463
Related-Issue: OSP-26191
@karelyatin karelyatin mentioned this pull request Oct 18, 2023
Closed
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/9462442e1cfb4508afece94882335363

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 45m 42s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 22m 48s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 31m 44s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 05s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 21s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 04s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 7m 36s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 52s
✔️ edpm-ansible-molecule-edpm_frr SUCCESS in 9m 15s
✔️ edpm-ansible-molecule-edpm_iscsid SUCCESS in 6m 03s

jpodivin
jpodivin requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. There is just one thing, I don't really think we need documentation for every single variable right away. But at least some of the more elaborate ones could use it. The desc doesn't have to be long. Just couple of words will suffice.

roles/edpm_neutron_ovn/meta/argument_specs.yml Show resolved Hide resolved
roles/edpm_neutron_ovn/meta/argument_specs.yml Outdated Show resolved Hide resolved
roles/edpm_neutron_ovn/meta/argument_specs.yml Show resolved Hide resolved
roles/edpm_neutron_ovn/meta/argument_specs.yml Show resolved Hide resolved
booxter
booxter reviewed Oct 20, 2023
View reviewed changes
roles/edpm_neutron_ovn/defaults/main.yml Outdated Show resolved Hide resolved
roles/edpm_neutron_ovn/defaults/main.yml Outdated

# rootwrap.conf
edpm_neutron_ovn_agent_rootwrap_DEFAULT_filters_path: '/etc/neutron/rootwrap.d,/usr/share/neutron/rootwrap'
edpm_neutron_ovn_agent_rootwrap_DEFAULT_exec_dirs: '/sbin,/usr/sbin,/bin,/usr/bin,/usr/local/bin,/usr/local/sbin,/etc/neutron/kill_scripts'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we don't spawn processes, then perhaps we don't need kill_scripts either

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, removed.

roles/edpm_neutron_ovn/tasks/install.yml Outdated
- {'path': "{{ edpm_neutron_ovn_agent_config_dir }}"}
- {'path': "/var/log/containers/neutron"}

- name: Enable virt_sandbox_use_netlink for healthcheck
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"healthcheck"? is it a proper description of the goal here? I think the idea is that the agent issues direct ip link commands on VF representors (or PF? not sure) and hence needs access to this kernel capability. No?

I see the same description used in this repo and in other tripleo adjacent repos for different services, and I suspect it's a remnant from an initial copy-paste that now spread uncontrollably.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes seems just a leftover, checked history:-
It was initially introduced with https://review.opendev.org/c/openstack/tripleo-heat-templates/+/629850, later ss usages were dropped with https://review.opendev.org/q/I137fe3211043b00b553db26b2f5930f98373496d and now healthcheck in full dropped openstack-k8s-operators/tcib#4 so it no longer needs required, will drop it.

karelyatin added a commit to karelyatin/neutron-operator that referenced this pull request Oct 20, 2023
@karelyatin
Create EDP Secret for Neutron OVN Agent
526b379 
OVN NB and SB DB connection strings are exported with
this secret as these are required by neutron-ovn-agent[1].

[1] openstack-k8s-operators/edpm-ansible#463
Related-Issue: OSP-26191
@karelyatin
Add role to setup neutron ovn agent
cb2f677 
This agent is used to provide QoS to hardware offloaded
ports on the compute nodes.

Related-Issue: OSP-26191
jpodivin
jpodivin reviewed Oct 23, 2023
View reviewed changes
Copy link
Contributor

@jpodivin jpodivin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.

@jpodivin jpodivin self-requested a review October 23, 2023 11:54
@openshift-ci openshift-ci bot added the lgtm label Oct 23, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jpodivin,karelyatin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit be9a3b4 into openstack-k8s-operators:main Oct 23, 2023
26 checks passed
karelyatin added a commit to openstack-k8s-operators/dataplane-operator that referenced this pull request Oct 23, 2023
@karelyatin
Add neutron-ovn service to deploy this agent on EDP Nodes
644a464 
Depends-On: openstack-k8s-operators/neutron-operator#231
Depends-On: openstack-k8s-operators/edpm-ansible#463
Related-Issue: OSP-26191
@karelyatin karelyatin mentioned this pull request Oct 23, 2023
Closed
karelyatin added a commit to karelyatin/dataplane-operator that referenced this pull request Oct 23, 2023
@karelyatin
Add neutron-ovn service to deploy this agent on EDP Nodes
b673b8e 
Depends-On: openstack-k8s-operators/neutron-operator#231
Depends-On: openstack-k8s-operators/edpm-ansible#463
Related-Issue: OSP-26191
@karelyatin karelyatin mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebtoor rebtoor rebtoor left review comments

@booxter booxter booxter left review comments

@jpodivin jpodivin jpodivin approved these changes

@lewisdenny lewisdenny Awaiting requested review from lewisdenny

Assignees

@jpodivin jpodivin

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karelyatin @booxter @rebtoor @jpodivin