Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make edpm_chrony role compliant with ansible-lint production profile #396

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Make edpm_chrony role compliant with ansible-lint production profile #396

merged 1 commit into from
Oct 8, 2023

Conversation

rebtoor
Copy link
Contributor

@rebtoor rebtoor commented Oct 5, 2023 •
edited
Loading

  • removed README.rst
  • removed tests since we rely on molecule for role testing

Depends-On: #415

@rebtoor rebtoor requested review from slagle and jpodivin October 5, 2023 09:48
@openshift-ci openshift-ci bot requested a review from stuggi October 5, 2023 09:48
@openshift-ci openshift-ci bot added the approved label Oct 5, 2023
@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/7608514a69e54029854f62c26b9b0f58

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 01m 37s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 43m 41s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 12m 46s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 34s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 44s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 28s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 48s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 19s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 5, 2023

recheck

RETRY_LIMIT, it seems that it couldn't download the libvirt collection due to a transient network error

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/413acf0dcf0c48de9fcc1d60430d0da3

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 03m 48s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 8m 23s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 49m 39s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 34s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 7m 17s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 29s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 8m 31s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 01s

@openshift-ci openshift-ci bot added the lgtm label Oct 6, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpodivin, rebtoor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 6, 2023

recheck

(RETRY_LIMIT)

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a63361748ab647749ae1d927da06759b

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 14m 15s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 41m 22s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 56m 40s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 47s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 38s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 31s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 49s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 7m 19s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 8, 2023

recheck

fatal: [localhost]: FAILED! => {"attempts": 10, "changed": false, "extra_data": {"data": null, "details": "504 Gateway Time-out: The server didn't respond in time.: ", "response": "<html><body><h1>504 Gateway Time-out</h1>\nThe server didn't respond in time.\n</body></html>\n"}, "msg": "HttpException: 504: Server Error for url: http://neutron-public-openstack.apps-crc.testing/v2.0/networks, 504 Gateway Time-out: The server didn't respond in time.: "}

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/a1280773c86141ffbb7565f90149a9ad

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 46m 42s
❌ podified-multinode-edpm-deployment-crc FAILURE in 59m 59s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 33m 38s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 34s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 51s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 13s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 58s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 57s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 8, 2023

recheck

(it didn't even start the deploy on the compute node)

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/c73a2668f19a4c22ad637d2b64e106d6

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 59m 07s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 42m 44s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 32m 14s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 5m 38s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 4m 52s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 10m 09s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 5m 52s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 5m 57s

@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 8, 2023

recheck

@softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://review.rdoproject.org/zuul/buildset/d38a30588e7448c3a02a5b948490441e

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 07m 32s
❌ podified-multinode-edpm-deployment-crc FAILURE in 1h 36m 37s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 1h 44m 25s
✔️ edpm-ansible-molecule-edpm_podman SUCCESS in 6m 37s
✔️ edpm-ansible-molecule-edpm_module_load SUCCESS in 5m 38s
✔️ edpm-ansible-molecule-edpm_kernel SUCCESS in 11m 03s
✔️ edpm-ansible-molecule-edpm_libvirt SUCCESS in 6m 26s
✔️ edpm-ansible-molecule-edpm_nova SUCCESS in 6m 44s

@rebtoor rebtoor changed the title Make edpm_chrony role compliant with ansible-lint production profile Make edpm_chrony role compliant with ansible-lint production profile Oct 8, 2023
@rebtoor
Copy link
Contributor Author

rebtoor commented Oct 8, 2023

recheck

@openshift-ci openshift-ci bot merged commit 0f2c39c into openstack-k8s-operators:main Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpodivin jpodivin jpodivin approved these changes

@slagle slagle Awaiting requested review from slagle

@stuggi stuggi Awaiting requested review from stuggi

Assignees

@jpodivin jpodivin

Labels
approved enforce-production-linting-profile lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rebtoor @jpodivin