Merge pull request #396 from rebtoor/edpm_chrony

Make `edpm_chrony` role compliant with ansible-lint `production` profile
openstack-k8s-operators · Oct 8, 2023 · 0f2c39c · 0f2c39c
2 parents 9916aee + 1cdbb00
commit 0f2c39c
Show file tree

Hide file tree

Showing 9 changed files with 8 additions and 148 deletions.
diff --git a/roles/edpm_chrony/README.rst b/roles/edpm_chrony/README.rst
diff --git a/roles/edpm_chrony/tasks/config.yml b/roles/edpm_chrony/tasks/config.yml
@@ -21,6 +21,6 @@
     dest: "{{ edpm_chrony_config_file_location }}"
     owner: root
     group: root
-    mode: 0644
+    mode: "0644"
   register: edpm_chrony_config
   notify: Restart chronyd
diff --git a/roles/edpm_chrony/tasks/online.yml b/roles/edpm_chrony/tasks/online.yml
@@ -4,7 +4,7 @@
   ansible.builtin.copy:
     src: files/chrony-online.service
     dest: /etc/systemd/system/chrony-online.service
-    mode: 0644
+    mode: "0644"
 
 - name: Enable chrony-online.service
   become: true

diff --git a/roles/edpm_chrony/tasks/sync.yml b/roles/edpm_chrony/tasks/sync.yml
@@ -18,6 +18,12 @@
 - name: Force NTP sync
   become: true
   ansible.builtin.command: chronyc makestep
+  register: _makestep_command_output
+  changed_when: _makestep_command_output.rc == 0
+  failed_when: _makestep_command_output.rc != 0
 
 - name: Ensure system is NTP time synced
   ansible.builtin.command: chronyc waitsync 30
+  register: _waitsync_command_output
+  changed_when: _waitsync_command_output.rc == 0
+  failed_when: _waitsync_command_output.rc != 0
diff --git a/roles/edpm_chrony/tests/all.yml b/roles/edpm_chrony/tests/all.yml
diff --git a/roles/edpm_chrony/tests/config.yml b/roles/edpm_chrony/tests/config.yml
diff --git a/roles/edpm_chrony/tests/install.yml b/roles/edpm_chrony/tests/install.yml
diff --git a/roles/edpm_chrony/tests/inventory.yml b/roles/edpm_chrony/tests/inventory.yml
diff --git a/roles/edpm_chrony/tests/upgrade.yml b/roles/edpm_chrony/tests/upgrade.yml