Update networking doc for service override change #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abays
reviewed
Sep 25, 2023
networking.md
Outdated
|
|
||
| Example: | ||
| Example: To expose the internal keystone endpoint using a MetalLB k8s LoadBalancer via the service override the `LoadBalancer` type in the spec and required annotations in the metadata has to be set: |
There was a problem hiding this comment.
I would put a comma after LoadBalancer via the service override. It helps the reader parse the long sentence.
Jira: OSP-26690 Depends-On: openstack-k8s-operators/openstack-operator#457
stuggi
force-pushed
the
handle_ingress_v3
branch
from
a224f4a to
6063a55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: OSP-26690
Depends-On: openstack-k8s-operators/openstack-operator#457