Use inventory_hostname in ceph related roles and play #2164
Conversation
|
Skipping CI for Draft Pull Request. |
cjeanner
force-pushed
the
ceph/inventory_hostname
branch
from
76c1593 to
652bd20
Compare
|
Thank you Cedric. This is a nice clean up. Let's make sure it doesn't break anything (e.g. IPv6) before merging. |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/e52d0ade349f406ba7974d7ac8b052a0 ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 09m 56s |
cjeanner
force-pushed
the
ceph/inventory_hostname
branch
from
652bd20 to
e07dfee
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0b6ec7322e6a45f889c1bf84b2fecd30 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 44m 13s |
|
It's failing in multinode-hci-deployment job: When checking the source of cephadm, we can see the inventory doesn't reflect the actual hostname: To correct that, we have 2 ways:
Having consistency between hostnames and inventory names sounds like the right thing imho. "just" need to make that consistency a realty. |
cjeanner
force-pushed
the
ceph/inventory_hostname
branch
3 times, most recently
from
73d10f9 to
67f904a
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8634ce8acafe456da6cb97c49eb12740 ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 09s |
cjeanner
force-pushed
the
ceph/inventory_hostname
branch
from
67f904a to
12b4780
Compare
Until now, the ceph playbook and associated roles were trying to be smart, but it created many other issues, and continues to create weird situations. With this patch, we reverse the burden, and base everything on the inventory. Since the inventory is generated by the Framework, and the Framework also sets the virtual machines hostname, we should be able to rely on the `inventory_hostname` only. This means the inventory must be consistent, if provided by external means. We therefore update/correct the hostname set on the various nodes to match the inventory.
cjeanner
force-pushed
the
ceph/inventory_hostname
branch
from
12b4780 to
d1f8d7b
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fultonj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Until now, the ceph playbook and associated roles were trying to be
smart, but it created many other issues, and continues to create weird
situations.
With this patch, we reverse the burden, and base everything on the
inventory.
Since the inventory is generated by the Framework, and the Framework
also sets the virtual machines hostname, we should be able to rely on
the
inventory_hostnameonly.This means the inventory must be consistent, if provided by external
means.
We therefore update/correct the hostname set on the various nodes to
match the inventory.
As a pull request owner and reviewers, I checked that:
Testing (not in commit message)