Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures we can use FQDN in ceph.yml playbook #2148

Closed
wants to merge 1 commit into from

Conversation

cjeanner
Copy link
Collaborator

Until now, there was an inconsistency between the 06-deploy-edpm.yml and
06-deploy-architecture.yml playbooks when it comes to ceph
configuration:
in the first one, ceph.yml play was instructed to use FQDN (via
ansible_fqdn fact), while the latter was using shortnames (via
ansible_hostname).

This leads to issues whenever we want to set FQDN on the various nodes
and in the inventory, since some stages of the ceph configuration is
checking for name consistency.

As a pull request owner and reviewers, I checked that:

  • Appropriate testing is done and actually running

Until now, there was an inconsistency between the 06-deploy-edpm.yml and
06-deploy-architecture.yml playbooks when it comes to ceph
configuration:
in the first one, ceph.yml play was instructed to use FQDN (via
ansible_fqdn fact), while the latter was using shortnames (via
ansible_hostname).

This leads to issues whenever we want to set FQDN on the various nodes
and in the inventory, since some stages of the ceph configuration is
checking for name consistency.
Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cjeanner. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fultonj
Copy link
Contributor

fultonj commented Jul 24, 2024

This might be sufficient. cephadm's hostname handling is complex. Let's make sure delta and delta-ipv6 can pass with this before merging.

@cjeanner
Copy link
Collaborator Author

Seems we can remove all of those *_spec_fqdn and leverage inventory_hostname and its variations (item in loop).

This is implemented in #2164 . Closing this one.

@cjeanner cjeanner closed this Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants