-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSHMEM Sessions (ctx hints) API #493
Conversation
…cation into wip/sessions
Also, for those interested, an example of a bare-minimum implementation of this proposed API in Sandia OpenSHMEM here: It simply ignores all hints... |
I address some key suggestions from the unofficial reading on Sept. 30th with commit 93f510e. Thanks for the feedback! Here are a few other notes from that meeting:
If anybody feels I missed something, please let me know! I unfortunately lost my PDF notes in a laptop crash, so I'm going by memory... |
Co-authored-by: James Dinan <[email protected]>
(cancelled) |
Special ballot diff: |
@@ -674,6 +674,10 @@ \section{Version 1.6} | |||
operations for team-based reductions. | |||
\ChangelogRef{teamreducetypes}% | |||
% | |||
\item Added the session routines, \FUNC{shmem\_session\_start} and | |||
\FUNC{shmem\_session\_stop}, which allow users to pass hints to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should these start/stop functions have been updated to include ctx
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, yes; I think these should have been renamed just like every other instance below.
How shall we handle this @jdinan? Do you think it's eligible for a doc edit?
This is a continuation of the Bundles proposal, so closes the #481 pull request. Sessions are a generalization of Bundles, so users can pass hints for context optimization that go beyond just chaining/bundling. There is more discussion on this API design in the original ticket, #189.
As usual, I appreciate any feedback - thanks in advance!